From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30371 invoked by alias); 15 Apr 2008 18:12:46 -0000 Received: (qmail 30360 invoked by uid 22791); 15 Apr 2008 18:12:46 -0000 X-Spam-Check-By: sourceware.org Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Apr 2008 18:12:23 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id BF3D73C03B; Tue, 15 Apr 2008 11:12:21 -0700 (PDT) Subject: Re: [RFA] mixed source+assembly from cli disassemble From: Michael Snyder To: Joel Brobecker Cc: Doug Evans , gdb-patches@sourceware.org In-Reply-To: <1207869204.31772.416.camel@localhost.localdomain> References: <20080404003857.A5A451C72B9@localhost> <1207776316.31772.410.camel@localhost.localdomain> <20080410081549.GA3589@adacore.com> <1207869204.31772.416.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 15 Apr 2008 20:32:00 -0000 Message-Id: <1208283141.3690.16.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00297.txt.bz2 On Thu, 2008-04-10 at 16:13 -0700, Michael Snyder wrote: > On Thu, 2008-04-10 at 01:15 -0700, Joel Brobecker wrote: > > > Going on a week... > > > No other comments, pro or con? > > > > I really like the idea, it's something that I often wished we'd have > > (and often asked for in graphical front-ends). I was going to review > > the patch, but wanted to ask others to comment on the user interface > > first. Once we agree on the syntax, then I can review the patch itself. > > > > Doug suggests to use an optional "/s" modifier. For instance: > > > > (gdb) disassemble ADDR -> regular assembly listing > > (gdb) disassemble /s ADDR -> intermixed source+assembly listing > > > > Is that OK with everyone? It's pretty consistent with what we do > > for the print command, so I like it. > > I think using a '/' modifier is good, since that's what > we use for print and examine and so on. > > The choice of the letter 's' is probably as good as any. > The only other one that comes to my mind is 'm' (for "mixed"). > And I'm not expressing a preference or objection. OK, in the absence of further discussion, patch approved. Doug, as the author, you get to choose the modifier flag. ;-)