Re: MI testsuite fix

Daniel Jacobowitz
2008-04-21T12:33:22Z

On Mon, Apr 21, 2008 at 12:35:58PM +0100, Pedro Alves wrote:
> Ok, that's what the attached does. Regtested on
> x86_64-unknown-linux-gnu, and confirmed that is also fixes the
> async MI testsuite on x86 due to the gate page warning.
>
> BTW, What is it that won't work with the look for .text first?

Beats me. But it probably means find_lowest_section doesn't work
on some platforms. e.g. the SEC_THREAD_LOCAL thing but that problem
is much newer than this code.

> > I'd also
> > approve a patch to reuse some of the qOffsets machinery for this, but
> > that would take more testing... if you want to look at that,
> > keep in mind that SEC_LOAD doesn't mean the VMA is useful; you
> > also need to check !SEC_THREAD_LOCAL.
>
> Now you've lost me. This is mapping absolute section addresses
> to section offsets. It doesn't seem symfile_map_offsets_to_segments
> or objfile_relocate would give any help here?

Well, anything that just carries offsets forwards from the previous
section is suspect. If the user gives us the addresses of .text and
.data, it'd be nice to move the containing segments appropriately.

> 2008-04-21 Pedro Alves <pedro@codesourcery.com>
>
> * symfile.c (syms_from_objfile): Don't warn if lowest loadable
> section is not a code section.

OK.

--
Daniel Jacobowitz
CodeSourcery