From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54919-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3541 invoked by alias); 2 Apr 2008 18:08:57 -0000
Received: (qmail 3530 invoked by uid 22791); 2 Apr 2008 18:08:57 -0000
X-Spam-Check-By: sourceware.org
Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 Apr 2008 18:08:17 +0000
Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) 	by bluesmobile.specifix.com (Postfix) with ESMTP id 5E07F3C234; 	Wed,  2 Apr 2008 11:08:15 -0700 (PDT)
Subject: Re: [Patch] Try2: -var-evaluate-expression [-f FORMAT] NAME
From: Michael Snyder <msnyder@specifix.com>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
In-Reply-To: <ft019v$62t$1@ger.gmane.org>
References: 	 <6D19CA8D71C89C43A057926FE0D4ADAA04290FFC@ecamlmw720.eamcs.ericsson.se> 	 <ft019v$62t$1@ger.gmane.org>
Content-Type: text/plain
Date: Wed, 02 Apr 2008 18:20:00 -0000
Message-Id: <1207159695.31772.122.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7)
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-04/txt/msg00043.txt.bz2

On Wed, 2008-04-02 at 17:22 +0400, Vladimir Prus wrote:
> Marc Khouzam wrote:
> 
> > 2008-04-01  Marc Khouzam  <marc.khouzam@ericsson.com>
> > 
> >         * mi/mi-cmd-var.c: Include "mi-getopt.h".
> >         (mi_parse_format): New.  Factored out from mi_cmd_var_set_format.
> >         (mi_cmd_var_set_format): Use new mi_parse_format.
> >         (mi_cmd_var_evaluate_expression): Support for -f option to specify
> >         format.
> >         * Makefile.in (mi-cmd-var.o): Update dependencies.
> > 
> >         * varobj.h (varobj_get_formatted_value): Declare.
> >         * varobj.c (my_value_of_variable): Added format parameter.
> >         (cplus_value_of_variable): Likewise.
> >         (java_value_of_variable): Likewise.
> >         (*(value_of_variable)): Likewise.
> 
> Is '*(value_of_variable)' really a name of a function? :-)

It is, actually -- but not in varobj.c.  Thanks for raising this.
Marc, we prefer not to have identifiers or file names abbreviated
in changelogs.