From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8494 invoked by alias); 17 Mar 2008 18:40:26 -0000 Received: (qmail 8485 invoked by uid 22791); 17 Mar 2008 18:40:25 -0000 X-Spam-Check-By: sourceware.org Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Mar 2008 18:40:08 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id DD20B3C402; Mon, 17 Mar 2008 11:40:06 -0700 (PDT) Subject: Re: [RFA] Implement -thread-info. From: Michael Snyder To: Vladimir Prus Cc: gdb-patches@sources.redhat.com In-Reply-To: References: <200802171833.26673.vladimir@codesourcery.com> <200802181038.04497.vladimir@codesourcery.com> <18361.64577.771676.184618@kahikatea.snap.net.nz> <200802201427.36288.vladimir@codesourcery.com> Content-Type: text/plain Date: Mon, 17 Mar 2008 18:40:00 -0000 Message-Id: <1205779206.19253.952.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00238.txt.bz2 On Fri, 2008-03-14 at 13:16 +0300, Vladimir Prus wrote: > Vladimir Prus wrote: > > > Vladimir Prus wrote: > > > >> I attach the revised version of the patch, including docs. Eli, is the > >> doc part OK? I intend to commit the code part in a week unless there are > >> objections. > > > > I have realized that while the patch is mostly about MI, it also > > touches generic code -- thread.c. Is that part of patch (attached again > > for convenience) OK? > > Ping? I'm looking back at your 02/20/08 patch -- is that the correct one? I noticed that your new version of info_threads_command always passes -1 to mi_info_threads, but then I checked and saw that the existing version of info_threads_command also ignores its argument. I think that's too bad, but at least it doesn't make the status quo worse. That was my only concern so far...