From: Michael Snyder <msnyder@specifix.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Markus Deuling <deuling@de.ibm.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Add proper error message instead of gdb_assert
Date: Mon, 03 Mar 2008 20:30:00 -0000 [thread overview]
Message-ID: <1204576230.19253.585.camel@localhost.localdomain> (raw)
In-Reply-To: <200803032000.m23K00SA027858@d12av02.megacenter.de.ibm.com>
On Mon, 2008-03-03 at 21:00 +0100, Ulrich Weigand wrote:
> Markus Deuling wrote:
>
> > when trying to put > 1 values into an array (fortran subrange) which
> > comes from a register, register_size is called with regnum == -1.
>
> You need to fix the caller to not do this, then.
>
> > This patch replaces that gdb_assert by a proper error message before
> > exiting:
>
> An "internal error" is neither more nor less "proper" than a failed
> assertion. Both say "there's a bug in GDB", and neither should be
> triggerable by normal user interaction.
Yes, but they're not equivalent. An assertion failure terminates
the session. Shouldn't we reserve that for situations that we
can reasonably assume are un-recoverable?
next prev parent reply other threads:[~2008-03-03 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 19:37 Markus Deuling
2008-03-03 19:55 ` Mark Kettenis
2008-03-03 20:29 ` Michael Snyder
2008-03-03 20:37 ` Mark Kettenis
2008-03-04 4:09 ` Eli Zaretskii
2008-03-03 20:39 ` Daniel Jacobowitz
2008-03-03 20:46 ` Markus Deuling
2008-03-03 21:12 ` Markus Deuling
2008-03-03 21:17 ` Daniel Jacobowitz
2008-03-03 20:00 ` Ulrich Weigand
2008-03-03 20:30 ` Michael Snyder [this message]
2008-03-03 20:25 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204576230.19253.585.camel@localhost.localdomain \
--to=msnyder@specifix.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox