From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24376 invoked by alias); 3 Mar 2008 20:29:11 -0000 Received: (qmail 24368 invoked by uid 22791); 3 Mar 2008 20:29:11 -0000 X-Spam-Check-By: sourceware.org Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Mar 2008 20:28:53 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id 39E903BF81; Mon, 3 Mar 2008 12:28:52 -0800 (PST) Subject: Re: [patch] Add proper error message instead of gdb_assert From: Michael Snyder To: Mark Kettenis Cc: deuling@de.ibm.com, gdb-patches@sourceware.org, uweigand@de.ibm.com In-Reply-To: <200803031955.m23Jt7cj019540@brahms.sibelius.xs4all.nl> References: <47CC5332.3020700@de.ibm.com> <200803031955.m23Jt7cj019540@brahms.sibelius.xs4all.nl> Content-Type: text/plain Date: Mon, 03 Mar 2008 20:29:00 -0000 Message-Id: <1204576131.19253.582.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00019.txt.bz2 On Mon, 2008-03-03 at 20:55 +0100, Mark Kettenis wrote: > > Sorry, but I don't see why your error message is "proper". The > gdb_assert() should never fail; the fact that it does means that you > have a bug elsewhere in gdb. Isn't that what the "internal error" call is for? The fact that there's a bug somewhere else in gdb is not necessarily a reason to abort the debugging session. It COULD be that severe -- but I don't think we necessarily need to assume it is. If so, we might just about as well call abort from main, because there are *always* bugs somewhere else in gdb... (1/2 )