From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29694 invoked by alias); 28 Feb 2008 19:39:14 -0000 Received: (qmail 29685 invoked by uid 22791); 28 Feb 2008 19:39:14 -0000 X-Spam-Check-By: sourceware.org Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Feb 2008 19:38:56 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id 2AAB13C233; Thu, 28 Feb 2008 11:38:55 -0800 (PST) Subject: Re: [patch] fix for c++/2416 From: Michael Snyder To: Aleksandar Ristovski Cc: Daniel Jacobowitz , gdb-patches@sourceware.org In-Reply-To: <47C70319.4050804@qnx.com> References: <47C5A5EE.6070107@qnx.com> <20080227193546.GA11796@caradoc.them.org> <47C5BE84.7050803@qnx.com> <20080227200019.GB12434@caradoc.them.org> <47C5D138.6020909@qnx.com> <20080227220659.GE14556@caradoc.them.org> <47C70319.4050804@qnx.com> Content-Type: text/plain Date: Fri, 29 Feb 2008 02:44:00 -0000 Message-Id: <1204227534.19253.459.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00488.txt.bz2 On Thu, 2008-02-28 at 13:53 -0500, Aleksandar Ristovski wrote: > See revisited diff (attached). Also, please find attached the testcase diff, I > added check for reference casting. Do I need to provide change log for tests too? Yes please. Thanks for your perseverance on this. Good job. (this is not formal approval, I haven't had a chance to review the new patch yet).