From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28225 invoked by alias); 15 Feb 2008 18:40:56 -0000 Received: (qmail 28215 invoked by uid 22791); 15 Feb 2008 18:40:56 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Feb 2008 18:40:34 +0000 Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) by igw2.br.ibm.com (Postfix) with ESMTP id 659CF17F4F1 for ; Fri, 15 Feb 2008 16:33:23 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m1FIeU274210718 for ; Fri, 15 Feb 2008 16:40:30 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m1FIeRFV007270 for ; Fri, 15 Feb 2008 16:40:27 -0200 Received: from [9.18.238.95] (dyn531828.br.ibm.com [9.18.238.95]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m1FIeQ22007244; Fri, 15 Feb 2008 16:40:27 -0200 Subject: Re: [rfc]: Replace current_gdbarch in sentinel-frame.c From: Thiago Jung Bauermann To: Ulrich Weigand Cc: Markus Deuling , GDB Patches In-Reply-To: <200802151743.m1FHhsnE027334@d12av02.megacenter.de.ibm.com> References: <200802151743.m1FHhsnE027334@d12av02.megacenter.de.ibm.com> Content-Type: text/plain Date: Fri, 15 Feb 2008 18:40:00 -0000 Message-Id: <1203100829.28012.6.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00262.txt.bz2 On Fri, 2008-02-15 at 18:43 +0100, Ulrich Weigand wrote: > Markus Deuling wrote: > > > @@ -54,7 +54,7 @@ sentinel_frame_prev_register (struct fra > > onto the corresponding hardware register. */ > > *optimized = 0; > > *lvalp = lval_register; > > - *addrp = register_offset_hack (current_gdbarch, regnum); > > + *addrp = register_offset_hack (get_frame_arch (next_frame), regnum); > > *realnum = regnum; > > This is not OK -- as the sentinel frame is always the innermost > frame, next_frame will always be NULL here. Actually, what I observe here when running GDB is that next_frame is the sentinel frame, probably because sentinel frame's next field points back to itself. -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center