From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15848 invoked by alias); 28 Jan 2008 20:26:05 -0000 Received: (qmail 15838 invoked by uid 22791); 28 Jan 2008 20:26:04 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jan 2008 20:25:43 +0000 Received: from mailhub3.br.ibm.com (unknown [9.18.232.110]) by igw3.br.ibm.com (Postfix) with ESMTP id 1CF94390066 for ; Mon, 28 Jan 2008 18:16:47 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0SKPee44300820 for ; Mon, 28 Jan 2008 18:25:40 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0SKPdwU029113 for ; Mon, 28 Jan 2008 18:25:40 -0200 Received: from [9.18.238.41] (dyn531774.br.ibm.com [9.18.238.41]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m0SKPd0F029109; Mon, 28 Jan 2008 18:25:39 -0200 Subject: Re: [RFC] Linux-specific ppc32 ABI From: Thiago Jung Bauermann To: Mark Kettenis Cc: luisgpm@linux.vnet.ibm.com, drow@false.org, brobecker@adacore.com, gdb-patches@sourceware.org In-Reply-To: <200801261535.m0QFZddH026156@brahms.sibelius.xs4all.nl> References: <1199991624.3343.19.camel@gargoyle> <20080111060629.GC12954@adacore.com> <1200066920.26270.9.camel@gargoyle> <20080111155733.GA3240@caradoc.them.org> <1200086736.26270.35.camel@gargoyle> <1201277155.11950.134.camel@localhost.localdomain> <200801261535.m0QFZddH026156@brahms.sibelius.xs4all.nl> Content-Type: text/plain Date: Mon, 28 Jan 2008 20:32:00 -0000 Message-Id: <1201551939.11950.185.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00653.txt.bz2 On Sat, 2008-01-26 at 16:35 +0100, Mark Kettenis wrote: > > It would be nice if someone could test this patch in other systems which > > use the SysV ppc32 ABI, to see if they actually implement what is in the > > ABI specification or if they also do what Linux actually does. If the > > former, this patch could go in. If the latter, we could use the > > suggested flag in gdbarch_tdep to restrict this fix only to Linux. > > It seems OpenBSD/powerpc is similar to Linux here. Without the patch I get > > FAIL: gdb.base/callfuncs.exp: Call function with many float arguments. > > which turns into a PASS if a apply the patch. The patch itself isn't > quite right though. Thanks for testing. > How about the attached diff? Fine by me, just one small issue: > + that, and stores floats without into 4 bytes > + aligned locations without converting them to The first "without" above shouldn't be there. -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center