From: Michael Snyder <msnyder@specifix.com>
To: gdb-patches@sourceware.org
Subject: minor comment clarification (cut and paste fix)
Date: Fri, 25 Jan 2008 02:50:00 -0000 [thread overview]
Message-ID: <1201219889.3263.183.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 93 bytes --]
Same like with corelow.c earlier... comment reflects the
read/write direction of the xfer.
[-- Attachment #2: readwrite.txt --]
[-- Type: text/plain, Size: 2185 bytes --]
2008-01-24 Michael Snyder <msnyder@specifix.com>
* procfs.c (procfs_xfer_partial): Comment, cut/paste error.
* win32-nat.c (win32_xfer_partial): Ditto.
* target.c (default_xfer_partial): Minor whitespace adjustment.
Index: procfs.c
===================================================================
RCS file: /cvs/src/src/gdb/procfs.c,v
retrieving revision 1.84
diff -u -p -r1.84 procfs.c
--- procfs.c 23 Jan 2008 11:26:28 -0000 1.84
+++ procfs.c 25 Jan 2008 00:06:56 -0000
@@ -4322,7 +4322,7 @@ procfs_xfer_partial (struct target_ops *
case TARGET_OBJECT_MEMORY:
if (readbuf)
return (*ops->deprecated_xfer_memory) (offset, readbuf, len,
- 0/*write*/, NULL, ops);
+ 0/*read*/, NULL, ops);
if (writebuf)
return (*ops->deprecated_xfer_memory) (offset, writebuf, len,
1/*write*/, NULL, ops);
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.148
diff -u -p -r1.148 win32-nat.c
--- win32-nat.c 23 Jan 2008 11:26:28 -0000 1.148
+++ win32-nat.c 25 Jan 2008 00:06:57 -0000
@@ -2037,7 +2037,7 @@ win32_xfer_partial (struct target_ops *o
case TARGET_OBJECT_MEMORY:
if (readbuf)
return (*ops->deprecated_xfer_memory) (offset, readbuf,
- len, 0/*write*/, NULL, ops);
+ len, 0/*read*/, NULL, ops);
if (writebuf)
return (*ops->deprecated_xfer_memory) (offset, (gdb_byte *) writebuf,
len, 1/*write*/, NULL, ops);
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.153
diff -u -p -r1.153 target.c
--- target.c 11 Jan 2008 00:12:43 -0000 1.153
+++ target.c 25 Jan 2008 00:06:58 -0000
@@ -1330,8 +1330,8 @@ default_xfer_partial (struct target_ops
do_cleanups (cleanup);
}
if (readbuf != NULL)
- xfered = ops->deprecated_xfer_memory (offset, readbuf, len, 0/*read*/,
- NULL, ops);
+ xfered = ops->deprecated_xfer_memory (offset, readbuf, len,
+ 0/*read*/, NULL, ops);
if (xfered > 0)
return xfered;
else if (xfered == 0 && errno == 0)
reply other threads:[~2008-01-25 0:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201219889.3263.183.camel@localhost.localdomain \
--to=msnyder@specifix.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox