From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12826 invoked by alias); 20 Nov 2012 04:58:08 -0000 Received: (qmail 12782 invoked by uid 22791); 20 Nov 2012 04:58:07 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mailout2.samsung.com (HELO mailout2.samsung.com) (203.254.224.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Nov 2012 04:58:01 +0000 Received: from epcpsbge4.samsung.com (epcpsbge4 [203.254.230.14]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MDR0015ASGCOAI0@mailout2.samsung.com> for gdb-patches@sourceware.org; Tue, 20 Nov 2012 13:57:59 +0900 (KST) Received: from epcpsbge4.samsung.com ( [172.20.52.123]) by epcpsbge4.samsung.com (EPCPMTA) with SMTP id B3.C2.32709.7DD0BA05; Tue, 20 Nov 2012 13:57:59 +0900 (KST) Received: from epextmailer02 ( [203.254.219.152]) by epcpsbge4.samsung.com (EPCPMTA) with SMTP id 63.C2.32709.6DD0BA05; Tue, 20 Nov 2012 13:57:58 +0900 (KST) Date: Tue, 20 Nov 2012 04:58:00 -0000 From: KARTHIKVENKATESH BHAT Subject: Re: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary To: Tom Tromey Cc: "gdb-patches@sourceware.org" Reply-to: kv.bhat@samsung.com MIME-version: 1.0 X-MTR: 20121120044317057@kv.bhat Msgkey: 20121120044317057@kv.bhat X-EPLocale: en_US.windows-1252 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20121120044317057@kv.bhat X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-transfer-encoding: base64 Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <12011231.483671353387478250.JavaMail.weblogic@epml02> DLP-Filter: Pass X-CFilter-Loop: Reflected Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00526.txt.bz2 SGkgVG9tDQpJIGhhZCBtaXNzZWQgb3V0IHRvIHBhc3RlIHRoZSBjaGFuZ2VM b2cgaW4gIHRoZSBtYWlsLiBQbGVhc2UgZmluZCB0aGUgcGF0Y2ggd2l0aCBj aGFuZ2Vsb2cgLQ0KDQpJbmRleDogQ2hhbmdlTG9nDQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9DaGFuZ2VM b2csdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE0ODM2DQpkaWZmIC11IC1w IC1yMS4xNDgzNiBDaGFuZ2VMb2cNCi0tLSBDaGFuZ2VMb2cJMTUgTm92IDIw MTIgMTY6MTI6MTEgLTAwMDAJMS4xNDgzNg0KKysrIENoYW5nZUxvZwkyMCBO b3YgMjAxMiAwNDozOTo0NiAtMDAwMA0KQEAgLTEsMyArMSw5IEBADQorMjAx Mi0xMS0yMCAgS2FydGhpayBCaGF0ICA8a3YuYmhhdEBzYW1zdW5nLmNvbT4N CisNCisJKiBpMzg2LXRkZXAuYyAoaTM4Nl9za2lwX3Byb2xvZ3VlKTogU2Vl IGlmIHdlDQorICAgICAgICAgICAgICBjYW4gZGV0ZXJtaW5lIHRoZSBlbmQg b2YgdGhlIHByb2xvZ3VlIHZpYSB0aGUgc3ltYm9sIHRhYmxlLg0KKwlJZiBz byB1c2UgdGhlIHNhbWUgaW5zdGVhZCBvZiBnb2luZyB0aHJvdWdoIHByb2xv Z3VlIGluc3RydWN0aW9ucy4NCisNCiAyMDEyLTExLTE1ICBQaWVycmUgTXVs bGVyICA8bXVsbGVyQHNvdXJjZXdhcmUub3JnPg0KIA0KIAlBUkkgZml4ZXM6 IG1vdmUgZ2RiX3dhaXQgYW5kIGdkYl9zdGF0IGhlYWRlcnMgdG8gY29tbW9u IHN1YmRpcmVjdG9yeS4NCkluZGV4OiBpMzg2LXRkZXAuYw0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvaTM4 Ni10ZGVwLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjM2Mg0KZGlmZiAt dSAtcCAtcjEuMzYyIGkzODYtdGRlcC5jDQotLS0gaTM4Ni10ZGVwLmMJMTIg Tm92IDIwMTIgMjE6NTk6MDYgLTAwMDAJMS4zNjINCisrKyBpMzg2LXRkZXAu YwkyMCBOb3YgMjAxMiAwNDozOTo0NyAtMDAwMA0KQEAgLTE1ODIsOCArMTU4 MiwzMCBAQCBpMzg2X3NraXBfcHJvbG9ndWUgKHN0cnVjdCBnZGJhcmNoICpn ZGJhDQogICBDT1JFX0FERFIgcGM7DQogICBnZGJfYnl0ZSBvcDsNCiAgIGlu dCBpOw0KKyAgY2FjaGUubG9jYWxzID0gLTE7IA0KKyAgQ09SRV9BRERSIGZ1 bmNfYWRkcjsNCisgIHN0cnVjdCBzeW10YWIgKnMgPSBmaW5kX3BjX3N5bXRh YiAoZnVuY19hZGRyKTsNCisNCisgIGlmIChmaW5kX3BjX3BhcnRpYWxfZnVu Y3Rpb24gKHN0YXJ0X3BjLCBOVUxMLCAmZnVuY19hZGRyLCBOVUxMKSkNCisg IHsNCisgICAgQ09SRV9BRERSIHBvc3RfcHJvbG9ndWVfcGMNCisgICAgICA9 IHNraXBfcHJvbG9ndWVfdXNpbmdfc2FsIChnZGJhcmNoLCBmdW5jX2FkZHIp Ow0KKyAgICANCisgICAgLyogR0NDIGFsd2F5cyBlbWl0cyBhIGxpbmUgbm90 ZSBiZWZvcmUgdGhlIHByb2xvZ3VlIGFuZCBhbm90aGVyDQorCSBvbmUgYWZ0 ZXIsIGV2ZW4gaWYgdGhlIHR3byBhcmUgYXQgdGhlIHNhbWUgYWRkcmVzcyBv ciBvbiB0aGUNCisJIHNhbWUgbGluZS4gIFRha2UgYWR2YW50YWdlIG9mIHRo aXMgc28gdGhhdCB3ZSBkbyBub3QgbmVlZCB0bw0KKwkga25vdyBldmVyeSBp bnN0cnVjdGlvbiB0aGF0IG1pZ2h0IGFwcGVhciBpbiB0aGUgcHJvbG9ndWUu ICBXZQ0KKwkgd2lsbCBoYXZlIHByb2R1Y2VyIGluZm9ybWF0aW9uIGZvciBt b3N0IGJpbmFyaWVzOyBpZiBpdCBpcw0KKwkgbWlzc2luZyAoZS5nLiBmb3Ig LWdzdGFicyksIGFzc3VtaW5nIHRoZSBHTlUgdG9vbHMuICAqLw0KKyAgICBp ZiAocG9zdF9wcm9sb2d1ZV9wYw0KKwkgICYmIChzID09IE5VTEwNCisJICAg ICAgfHwgcy0+cHJvZHVjZXIgPT0gTlVMTA0KKwkgICAgICB8fCBzdHJuY21w IChzLT5wcm9kdWNlciwgIkdOVSAiLCBzaXplb2YgKCJHTlUgIikgLSAxKSA9 PSAwDQorCSAgICAgIHx8IHN0cm5jbXAgKHMtPnByb2R1Y2VyLCAiY2xhbmcg Iiwgc2l6ZW9mICgiY2xhbmcgIikgLSAxKSA9PSAwKSkNCisJICByZXR1cm4g IG1heCAoc3RhcnRfcGMsIHBvc3RfcHJvbG9ndWVfcGMpOw0KKyAgfQ0KKw0K DQpNYW55IG9mIHRoZSBjdXJyZW50IGdjYyB0ZXN0IGNhc2VzIHRlc3QgdGhp cyBmZWF0dXJlLiBXZSBjYW4gcmVwcm9kdWNlIHRoaXMgZmFpbHVyZSBpbiBj bGFuZyB3aXRoIGV4aXN0aW5nIHRlc3RjYXNlcyBzdWNoIGFzIGJyZWFrLWFs d2F5cy5leHAsc3RlcC10ZXN0LmV4cCBldGMgd2hlbiB0ZXN0ZWQgd2l0aCBj bGFuZyBjb21waWxlZCBiaW5hcnkuIA0KSGVuY2UgaSdtIHVzaW5nIHRoZSBl eGlzdGluZyB0ZXN0IGNhc2VzLg0KDQpUb20+ICsgIElzIHRoZXJlIGFueSBv dGhlciB3YXk/DQoNCkN1cnJlbnRseSBpIGNvdWxkIGNvbWUgdXAgd2l0aCB0 aGlzIGZpeC4gU2ltaWxhciBmaXggaXMgdXNlZCBpbiBjYXNlIG9mIEFSTSBh cmNoaXRlY3R1cmUuDQoNClJlZ2FyZHMNCkthcnRoaWsNCg0KLS0tLS0tLSBP cmlnaW5hbCBNZXNzYWdlIC0tLS0tLS0NClNlbmRlciA6IFRvbSBUcm9tZXk8 dHJvbWV5QHJlZGhhdC5jb20+DQpEYXRlIDogTm92IDIwLCAyMDEyIDAwOjQ5 IChHTVQrMDk6MDApDQpUaXRsZSA6IFJlOiBbUEFUQ0hdIEZpeCBmb3IgaW5j b3JlY3QgYnJlYWtwb2ludCBzZXQgaW4gY2FzZSBvZiBjbGFuZyBjb21waWxl ZCBiaW5hcnkNCg0KPj4+Pj4gIkthcnRoaWsiID09IEtBUlRISUtWRU5LQVRF U0ggQkhBVCB3cml0ZXM6DQoNCkthcnRoaWs+IEkgd2FudGVkIHRvIGFkZCBh IHBhdGNoIGluIGkzODYtdGRlcC5jIC4gIFNpbWlsYXIgdG8gd2hhdCBpcyBk b25lIGluDQpLYXJ0aGlrPiBvdGhlciBhcmNoaXRlY3R1cmVzIHN1Y2ggYXMg QVJNLA0KS2FydGhpaz4gaW5zdGVhZCBvZiBhY3R1YWxseSBnb2luZyB0aHJv dWdoIHRoZSBjb21wbGV0ZSBwcm9sb2d1ZSBpZiB3ZSBjYW4gdXNlDQpLYXJ0 aGlrPiB0aGUgc3ltYm9sIHRhYmxlIGluZm9ybWF0aW9uIHRvIHJlc29sdmUg cHJvbG9ndWUgZW5kLg0KDQpJJ20gbm90IHRoZSBwZXJzb24gdG8gcmV2aWV3 IHRoaXMgcGF0Y2gsIGJ1dCBJIGRpZCBub3RpY2UgdGhhdCBpdCBpcw0KbWlz c2luZyBhIENoYW5nZUxvZyBlbnRyeSBhbmQgYWxzbyBhIHRlc3QgY2FzZS4N Cg0KS2FydGhpaz4gKyAgICAgICB8fCBzdHJuY21wIChzLT5wcm9kdWNlciwg IkdOVSAiLCBzaXplb2YgKCJHTlUgIikgLSAxKSA9PSAwDQpLYXJ0aGlrPiAr ICAgICAgIHx8IHN0cm5jbXAgKHMtPnByb2R1Y2VyLCAiY2xhbmcgIiwgc2l6 ZW9mICgiY2xhbmcgIikgLSAxKSA9PSAwKSkNCg0KSXMgdGhlcmUgYW55IG90 aGVyIHdheT8NCg0KVG9t >From gdb-patches-return-96089-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Nov 20 05:30:21 2012 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 5982 invoked by alias); 20 Nov 2012 05:30:20 -0000 Received: (qmail 5945 invoked by uid 22791); 20 Nov 2012 05:30:19 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (149.20.54.216) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Nov 2012 05:30:10 +0000 Received: from localhost (cpe-66-108-117-132.nyc.res.rr.com [66.108.117.132]) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4EA63583897; Mon, 19 Nov 2012 21:30:10 -0800 (PST) Date: Tue, 20 Nov 2012 05:30:00 -0000 Message-Id: <20121120.003006.1287326526424655175.davem@davemloft.net> To: gdb-patches@sourceware.org CC: stan@codesourcery.com, kcy@codesourcery.com Subject: [PATCH] Fix 'info os' crashes on sparc. From: David Miller Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2012-11/txt/msg00527.txt.bz2 Content-length: 1304 The get_number_of_cpu_cores() function really needs to be split out into a target cpu specific helper function. Every single Linux architecture has a different layout for this file, and the amount of commonality between architectures approaches zero. Furthermore, the failure mode when this function can't find the number of cpus properly makes for extremely difficult diagnosis. Because we return with zero, malloc() a zero sized area, and immediately write past the end and corrupt the malloc() pools. Anyways, for now, ok to commit this? gdb/ 2012-11-19 David S. Miller * common/linux-osdata.c (get_number_of_cpu_cores): Add support for parsing the layout of sparc /proc/cpuinfo files. diff --git a/gdb/common/linux-osdata.c b/gdb/common/linux-osdata.c index afe3e75..5db286b 100644 --- a/gdb/common/linux-osdata.c +++ b/gdb/common/linux-osdata.c @@ -266,8 +266,16 @@ get_number_of_cpu_cores (void) char buf[512]; char *p = fgets (buf, sizeof (buf), f); - if (p && strncmp (buf, "processor", 9) == 0) - ++cores; + if (p) + { + if (strncmp (buf, "processor", 9) == 0) + ++cores; + else if (strncmp (buf, "ncpus active\t: ", 15) == 0) + { + sscanf (p + 15, "%d", &cores); + break; + } + } } fclose (f);