Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb] Detect corrupt link map with zero l_ld and l_addr
Date: Tue, 29 Sep 2026 09:19:46 +0200	[thread overview]
Message-ID: <11e76ef6-e59b-4c4a-91a8-276398b0d785@suse.de> (raw)
In-Reply-To: <1fac98af-e3d1-47ba-a0b6-c97344bfe6c9@suse.de>

On 9/28/26 5:30 PM, Tom de Vries wrote:
>> Returning 0 means we stop reading the shared library list, is that
>> expected?  The known case of this isn't really that the shared library
>> list is corrupted, just that this entry is incomplete.  We could maybe
>> skip over this entry and keep reading the list, to be able to present
>> all the loaded shared libraries to the user?
>>
> 
> Hi Simon,
> 
> thanks for the review.
> 
> I think you're right, using continue instead of return 0 is more 
> appropriate.
> 
>> Is the warning printed every time the library list is read (like at each
>> stop)?  Does that become annoying for the user?
>>
>> In the end maybe we don't care too much about these concerns, because
>> it's for one specific version of one specific distro, and only when
>> debugging programs that use multiple namespaces (which are quite rare I
>> think).
>>
> 
> It could be annoying, agreed.
> 
> I'm treating this though as a corruption that is triggered by one 
> specific version of one specific distro, but might happen otherwise.
> 
> So I think there is information in how many times the warning triggers.
> 
> We could keep track for which shared libs the warning triggers, and emit 
> a summary instead.  But I don't think it's worth the bother at this point.
> 

I've tested the continue approach, and submitted a v3 ( 
https://sourceware.org/pipermail/gdb-patches/2026-September/230704.html ).

Thanks,
- Tom

> Thanks,
> - Tom


      reply	other threads:[~2026-09-29  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27  6:30 Tom de Vries
2026-09-28 14:54 ` Simon Marchi
2026-09-28 15:30   ` Tom de Vries
2026-09-29  7:19     ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11e76ef6-e59b-4c4a-91a8-276398b0d785@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox