Re: [PATCH] Bug 20936 - documentation review

[Ivo Raisr <ivo.raisr@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]



On 31.1.2017 16:32, Eli Zaretskii wrote:
>> From: Ivo Raisr <ivo.raisr@oracle.com>
>> Date: Tue, 31 Jan 2017 05:47:19 +0100
>>
>> Please can I get a documentation review for the attached patch.
>> The affected documentation files are:
>> gdb/doc/gdb.texinfo
>>
>> The patch has been successfully review by Yao Qi <qiyaoltc@gmail.com>.
>
> Sorry for not responding earlier.
>
> The patch for gdb.texinfo is okay, but I don't see the ChangeLog
> entries.  And what about NEWS?

Thank you for review.
ChangeLog entries are attached.
An entry for gdb/NEWS is also attached (I hope that's what you were 
referring to).
I.

[-- Attachment #2: ChangeLog.doc.entry --]
[-- Type: text/plain, Size: 177 bytes --]

ChangeLog entry:
2017-01-17  Ivo Raisr  <ivo.raisr@oracle.com>

	PR tdep/20936
	* gdb.texinfo: (Standard Target Features): Document SPARC features.
	(Sparc Features): New node.

[-- Attachment #3: ChangeLog.testsuite.entry --]
[-- Type: text/plain, Size: 150 bytes --]

ChangeLog entry:
2017-01-17  Ivo Raisr  <ivo.raisr@oracle.com>

	PR tdep/20936
	* gdb.xml/tdesc-regs.exp: Provide sparc core registers for the tests.

[-- Attachment #4: ChangeLog.entry.tdesc-003 --]
[-- Type: text/plain, Size: 1096 bytes --]

ChangeLog entry:
2017-01-17  Ivo Raisr  <ivo.raisr@oracle.com>

	PR tdep/20936
	Provide and use sparc32 and sparc64 target description XML files.
	* features/sparc/sparc32-cp0.xml, features/sparc/sparc32-cpu.xml,
	features/sparc/sparc32-fpu.xml: New files for sparc 32-bit.
	* features/sparc/sparc64-cp0.xml, features/sparc/sparc64-cpu.xml,
	features/sparc/sparc64-fpu.xml: New files for sparc 64-bit.
	* features/sparc/sparc32-solaris.xml: New file.
	* features/sparc/sparc64-solaris.xml: New file.
	* features/sparc/sparc32-solaris.c: Generated.
	* features/sparc/sparc64-solaris.c: Generated.
	* sparc-tdep.h: Account for differences in target descriptions.
	* sparc-tdep.c (sparc32_register_name): Use target provided registers.
	(sparc32_register_type): Use target provided registers.
	(validate_tdesc_registers): New function.
	(sparc32_gdbarch_init): Use tdesc_has_registers.
	Set pseudoregister functions.
	* sparc64-tdep.c (sparc64_register_name): Use target provided registers.
	(sparc64_register_type): Use target provided registers.
	(sparc64_init_abi): Set pseudoregister functions.

[-- Attachment #5: gdb.NEWS.patch --]
[-- Type: text/x-patch, Size: 271 bytes --]

diff --git a/gdb/NEWS b/gdb/NEWS
index 21e8cd3..b71b1ea 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -47,6 +47,8 @@
      end
    end
 
+* Target descriptions can now describe registers for sparc32 and sparc64.
+
 * New native configurations
 
 FreeBSD/mips			mips*-*-freebsd