From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-145758-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 46210 invoked by alias); 3 Mar 2018 06:29:17 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 46201 invoked by uid 89); 3 Mar 2018 06:29:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Mar 2018 06:29:15 +0000
Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 625671E059;	Sat,  3 Mar 2018 01:29:13 -0500 (EST)
Subject: Re: [PATCHv3 1/2] gdb/amd64: Ignore zero sized fields when calling functions
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Eli Zaretskii <eliz@gnu.org>
References: <cover.1520021226.git.andrew.burgess@embecosm.com> <a99f02ac2ff15d7c4ffffda9fc7125267a53f6fd.1520021226.git.andrew.burgess@embecosm.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <11cad30a-02f3-f107-f8ac-4166f0312f1b@simark.ca>
Date: Sat, 03 Mar 2018 06:29:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <a99f02ac2ff15d7c4ffffda9fc7125267a53f6fd.1520021226.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-03/txt/msg00087.txt.bz2

On 2018-03-02 03:09 PM, Andrew Burgess wrote:
> In some cases passing an argument to a function on amd64, or attempting
> to fetch the return value, can trigger an assertion failure within GDB.
> An example of a type that would trigger such an error is:
> 
>   struct foo_t
>   {
>     long double a;
>     struct {
>       struct {
>         /* Empty.  */
>       } es1;
>     } s1;
>   };
> 
> GCC does permit empty structures, so we should probably support this.
> 
> The test that exposes this bug is in the next commit along with the
> RiscV support.

Good job on the test :).  This patch LGTM.

Simon