From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 0E22E38A2414 for ; Wed, 18 Mar 2020 21:41:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0E22E38A2414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584567693; bh=5ePDhjjtJ539QXJzsDpLWTgob0kPl2PZBedLBYTm+aI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=eyv72uDU2SHiq1DdnNXFzAj93nIgmvnniiyBFe4i3M2zdDDMIozJFwzv20+4NikYg MSRjrN0qZWPkWFkrNzv/DW0CldMND0uqiduHWR1d3NBGV/j4BW5i29dTXgCCDKHa0m Qf4Bmqr48nGGl34Jl/Lk8Ori2dPulBVp3jet3WYA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MGQj7-1j550L2cmL-00GpdP; Wed, 18 Mar 2020 22:41:33 +0100 Subject: Re: [PATCH] Disable get_ptrace_pid for NetBSD To: Simon Marchi , gdb-patches@sourceware.org Cc: Tom Tromey References: <20200318162915.15043-1-n54@gmx.com> <3ea12183-68f2-94c4-d7d0-504b88a79ed4@simark.ca> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <11c3372f-256b-6c92-ef45-fbb351ed0693@gmx.com> Date: Wed, 18 Mar 2020 22:40:15 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <3ea12183-68f2-94c4-d7d0-504b88a79ed4@simark.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c6ypbP4Fvp0TcH4CHuylWfgu81x1pQMTZ" X-Provags-ID: V03:K1:EWbb//ZrFbAViJ1jVmvGX+omxHi1byK5pZaxS2VSSJqE4UFd6FE FWRASVCyp3lQtxJvFTMIQzYifb7xw2vHIBSOfuX7IKfCDtPEolelR4hDOSU7m50VMMz4yak SLK7s9eWWZNCAjJ+rn5WLUkJux0zu6+hP18GTlDr9aNEICR0sSS5oh7fWQBLskRXbjs5z0Z 87grvq0dSB4z1/uYY+J1A== X-UI-Out-Filterresults: notjunk:1;V03:K0:+tUL4UOzVow=:OjhK51ZKeKB05pinaVdNOf 0E6m2TFiGRZ1iPovP/2nVpjH/+HjxODVD5hXtk6TAnvcuvM1e+HmHs4uBThxRNvklJJq6Dqtn GLbavR6C16u17rSGICqY+hGI/+nPc0CsfbOLL6/0xDaMX67l2hWVWAtlbDA0FzwLngAZw81Id N0wnvBO0nkYof+BsAvsmAipD3qVD8gAiqHxuwjFzbLhlYxhvv75UAmI6sC0ampk5hD+7JRk6X biQyEbJdMoh5QfiXhsz/PuWHWRlvqNpeq+czs9Gs6RKrfEcCjVDHhdKPYdm7d/+GMrFPq9DuX Ja7/lUQTcYMqXB6VBRYPb1RqegxR0FGVbxr0XdmapWoE+NHAW5DaihoJLJangMGbmSFHRlkfz cwOvUWz3YZxQLaWWWlRKlrSWA4zy/aSXkC7A1NMTvIjOcntFExEKqsV/d1z4Mm7cipqmsql0l Cnzv8QKvHbGg+6eHQa9bwoEbD/GIPJo9W0DHteYs16ckDl3KnhMOYVXy/eYV1boF9mwNXMTEN mPIbAjiNjPllBRy6iUvlz2Bq8r/2oxowr5zmmpRqqUWSy0mQpVQ1iopQiP2SFaZh4v+/94C4M o+Nv12xME6aUvPxf/VWGuSuDltQATVp35k/PVFk5+v/oA5x5H11/6g3DgJd6EhA/YqTu3Jhok lAL7b/4f4bGb4/riiQA3O+zeKVHCBflU5yEemWO0dG4B8SBwFk8SRwlmipTQDwd9Jz48l0+uy kF3U2ucEccdjskLx+pyNIg5XE7vrBYZeUoSkB8l04dDNdYRQn35WardT816tOKkQfCvhYbHEf EmDfKvHwU7IgybQDOA8bukEvW68Qc+g67BOdHzlKkeNbo4P2MQlj2wMoqzKQ9/jblg0rwGQHw TAlKFYOKhwoDgLA79WmHSk9mWCv9IpYTEvcy5djoWS9wit5bE+YwpbgUfh9Tt8rxQw+luFdYC KBsOxnMR9SnLyUAch9RniaQ4N+VfX+2F7HWG+rlpsM7buFXtevHdZhpdpKB4DTtOQK6SSfNdV iRjGHU8DvyecugxMEM1adsKq3OZEGdoziAhWvYlpKbyuqCOf29xAXTJLKLyVVUJtftVeMyOjN D2xXILSz5oqwdAE0S37qFD1NsZficBJ47e+IxBgHiLDXJWBLlMOk84hQ6AFPVlfQ3lSCZIyLL NxZ86dKR7yWJ4VjNVYFALnqXePPFceOOVL6mg4aEDcou67IwSz8H5euWsxRJBzw6lInrg= X-Spam-Status: No, score=-25.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 21:41:50 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c6ypbP4Fvp0TcH4CHuylWfgu81x1pQMTZ Content-Type: multipart/mixed; boundary="dPFuBQtNlc5zI2XhrxfQWfy8gXXk5wtDE"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , gdb-patches@sourceware.org Cc: Tom Tromey Message-ID: <11c3372f-256b-6c92-ef45-fbb351ed0693@gmx.com> Subject: Re: [PATCH] Disable get_ptrace_pid for NetBSD References: <20200318162915.15043-1-n54@gmx.com> <3ea12183-68f2-94c4-d7d0-504b88a79ed4@simark.ca> In-Reply-To: <3ea12183-68f2-94c4-d7d0-504b88a79ed4@simark.ca> --dPFuBQtNlc5zI2XhrxfQWfy8gXXk5wtDE Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 18.03.2020 22:15, Simon Marchi wrote: > On 2020-03-18 12:29 p.m., Kamil Rytarowski wrote: >> Unlike most other Operating Systems, NetBSD tracks both pid and lwp. >> The process id on NetBSD is stored always in the pid field of ptid. >> >> gdb/ChangeLog: >> >> * inf-ptrace.h: Disable get_ptrace_pid on NetBSD. >> * inf-ptrace.c: Likewise. >> * (inf_ptrace_target::resume): Update. >> * (inf_ptrace_target::xfer_partial): Likewise. >> --- >> gdb/ChangeLog | 7 +++++++ >> gdb/inf-ptrace.c | 19 +++++++++++++++++-- >> gdb/inf-ptrace.h | 2 ++ >> 3 files changed, 26 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 84964dc00ac..36e333ec8ba 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,10 @@ >> +2020-03-18 Kamil Rytarowski >> + >> + * inf-ptrace.h: Disable get_ptrace_pid on NetBSD. >> + * inf-ptrace.c: Likewise. >> + * (inf_ptrace_target::resume): Update. >> + * (inf_ptrace_target::xfer_partial): Likewise. >> + >> 2020-03-17 Kamil Rytarowski >> >> * regformats/regdef.h: Put reg in gdb namespace. >> diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c >> index db17a76d946..e8bf66ed45f 100644 >> --- a/gdb/inf-ptrace.c >> +++ b/gdb/inf-ptrace.c >> @@ -313,8 +313,12 @@ inf_ptrace_target::kill () >> target_mourn_inferior (inferior_ptid); >> } >> >> +#ifndef __NetBSD__ >> /* Return which PID to pass to ptrace in order to observe/control the= >> - tracee identified by PTID. */ >> + tracee identified by PTID. >> + >> + Unlike most other Operating Systems, NetBSD tracks both pid and lw= p >> + and avoids this function. */ >> >> pid_t >> get_ptrace_pid (ptid_t ptid) >> @@ -328,6 +332,7 @@ get_ptrace_pid (ptid_t ptid) >> pid =3D ptid.pid (); >> return pid; >> } >> +#endif >> >> /* Resume execution of thread PTID, or all threads if PTID is -1. If= >> STEP is nonzero, single-step it. If SIGNAL is nonzero, give it >> @@ -344,7 +349,13 @@ inf_ptrace_target::resume (ptid_t ptid, int step,= enum gdb_signal signal) >> single-threaded processes, so simply resume the inferior. */ >> pid =3D inferior_ptid.pid (); >> else >> - pid =3D get_ptrace_pid (ptid); >> + { >> +#ifdef __NetBSD__ >> + pid =3D ptid. pid(); >> +#else >> + pid =3D get_ptrace_pid (ptid); >> +#endif >> + } >=20 > To avoid the ifdefs in this more complex code, can't you use a gdb_ptra= ce function like in > the other patches? This time, it would look like: >=20 > static int > gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_ARG3 add= r, > PTRACE_TYPE_ARG4 data) > { > #ifdef __NetBSD__ > return ptrace (request, ptid.pid (), addr, data); > #else > pid_t pid =3D get_ptrace_pid (ptid); > return ptrace (request, pid, addr, data); > #endif > } >=20 > Simon >=20 I will go for it, but only for a selection of ptrace () calls in this fil= e. In certain places there would need to be need to compose ptid_t out of plain pid. Another case is PT_TRACE_ME. --dPFuBQtNlc5zI2XhrxfQWfy8gXXk5wtDE-- --c6ypbP4Fvp0TcH4CHuylWfgu81x1pQMTZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5ylT8ACgkQS7MI6bAu dmxnwg//WFhVTV2z8XZ9gBumtzmZYQifHL/nPBIBaQCYEM/hz2Mio1S4V+oLHvXw cqpfMQAw9w7wwUZ7Qjleiyj5kGd4Yxqyz+t2FW4EO0O9MjpurWdGDDm6E57RIyLc 8w+XhIP0XMIcAXd5asXF9jNtJL57z/7OWHVKX9RygWGMi1SHif5m40TiHdd66SpZ rCfkH8l1o320g2XXTbGxNLBpZ95KNhI5eBsi+dwt8pTwZsOe46+1KD15ScGTHXVL sPnCoFBvEMsI+0zELF4jFaGa4A4QaiJvX7H3eUKOK0H1RD4RirliLjKRR575eDEc 3lDyTeEe7ic0zPJXKYtz/RVsKADrYn3zqHIHBu02Ly3j1dZL/ZVKvqZSFT3F2A2k EHcWRSQJDfKjRpkSJaTPf27P5kivdLq2VCA0oUJtLnE/XgmUxQDg5ejo8mPm5NUa G6GGu1DYoqk0C7bWe5p0iM9/lIfDiRYZyQkIC5O1XNghcjkX4pyB7ejnZ+5+HxhQ OqzrtuGbL30c+qQoPcTqYGsQYL2BFTC5228PXH0E4pUMwvREZIS4vWyJSfLew+IB wEyj+XQGXDKgYpZIBq/jCUnnaz43hHMzWMbDLlBNrqqlAagt/M6vnfpF/vy/4aGn TMl/Rvric6SNeOtSaljbZLic57jujcsOeoLkY5hip91oos+0xCs= =7H03 -----END PGP SIGNATURE----- --c6ypbP4Fvp0TcH4CHuylWfgu81x1pQMTZ--