From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80070 invoked by alias); 17 May 2016 18:35:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80046 invoked by uid 89); 17 May 2016 18:35:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 May 2016 18:35:32 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FADC7F36F; Tue, 17 May 2016 18:35:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4HIZT0Q024154; Tue, 17 May 2016 14:35:30 -0400 Subject: Re: [PATCH v2] Add mi-threads-interrupt.exp test (PR 20039) To: Simon Marchi , gdb-patches@sourceware.org References: <1462472343-17772-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <11ba81b6-e28c-0d78-4a23-e1cce17e19b0@redhat.com> Date: Tue, 17 May 2016 18:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1462472343-17772-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00270.txt.bz2 On 05/05/2016 07:19 PM, Simon Marchi wrote: > Add a new test for PR 20039. The test spawns new threads, then tries to > interrupt, continue, and interrupt again. This use case was fixed by > commit 5fe966540d6b748f825774868463003700f0c878 in master, but gdb 7.11 > is affected (so if you try it on the gdb-7.11-branch right now, the test > will fail). > > New in v2, the test now handles mi-async on mode properly. The failure > was specific to mi-async off, but I don't think it's bad to test the > same thing under async on mode. I added a little hack when running in > async mode to work around bug 20045. > > I also removed one continue/interrupt pair, as a single one was enough to > trigger the problem. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-threads-interrupt.c: New file. > * gdb.mi/mi-threads-interrupt.exp: New file. OK. Thanks, Pedro Alves