From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 68B6F385C426
 for <gdb-patches@sourceware.org>; Mon, 23 Mar 2020 00:36:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68B6F385C426
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id CB1F01E5F8;
 Sun, 22 Mar 2020 20:35:59 -0400 (EDT)
Subject: Re: [PATCH 4/7] [gdb/testsuite] use args as lib list for jit-elf tests
From: Simon Marchi <simark@simark.ca>
To: Mihails Strasuns <mihails.strasuns@intel.com>, gdb-patches@sourceware.org
References: <20200218124339.11270-1-mihails.strasuns@intel.com>
 <20200218124339.11270-5-mihails.strasuns@intel.com>
 <205aa76e-2c38-4944-dfb6-86155be15d40@simark.ca>
Message-ID: <11b5e307-f1e3-8a3a-ee91-36f711c496fd@simark.ca>
Date: Sun, 22 Mar 2020 20:35:59 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <205aa76e-2c38-4944-dfb6-86155be15d40@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-16.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <http://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2020 00:36:01 -0000

On 2020-03-22 8:04 p.m., Simon Marchi wrote:
>> +proc compile_jit_main {options} {
>> +    global srcdir subdir testfile2 srcfile2 binfile2
>> +    set testfile2 jit-elf-main
>> +    set srcfile2 ${testfile2}.c
>> +    set binfile2 [standard_output_file $testfile2.so]
> 
> These variables don't need to have the suffix `2` anymore, let's remove it.

In fact, correct me if I'm wrong, but I think testfile2, srcfile2 and binfile2 don't need to be global.

Simon