Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix watch_thread_num testcase for ppc32
Date: Wed, 09 Jan 2008 03:34:00 -0000	[thread overview]
Message-ID: <1199849652.22083.20.camel@gargoyle> (raw)

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi folks,

The watch_thread_num.exp testcase was timing out on a number of
iterations for PPC32, while giving a full pass for PPC64. Removing the
usleep(1) call fixed the problem. It gives full passes for both PPC
32/64.

Ok to commit?

-- 
Luis Machado
Software Engineer 
IBM Linux Technology Center

[-- Attachment #2: thread_num_test_fix.diff --]
[-- Type: text/x-patch, Size: 673 bytes --]

2008-01-09  Luis Machado  <luisgpm@br.ibm.com>

	* testsuite/gdb.base/watch_thread_num.c: Change shared_var to long
	and remove usleep call.

Index: gdb/testsuite/gdb.base/watch_thread_num.c
===================================================================
--- gdb.orig/testsuite/gdb.base/watch_thread_num.c	2008-01-08 19:21:06.000000000 -0800
+++ gdb/testsuite/gdb.base/watch_thread_num.c	2008-01-08 19:28:29.000000000 -0800
@@ -53,10 +53,7 @@
     int my_number = (long) arg;
     /* Don't run forever.  Run just short of it :)  */
     while (shared_var > 0)
-      {
         shared_var++;
-	usleep (1); /* Loop increment.  */
-      }
 
     pthread_exit (NULL);
 }

             reply	other threads:[~2008-01-09  3:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09  3:34 Luis Machado [this message]
2008-01-09  4:15 ` Joel Brobecker
2008-01-09  9:39   ` Luis Machado
2008-01-09 12:48     ` Daniel Jacobowitz
2008-01-09 12:55       ` Luis Machado
2008-01-09 10:05 ` Andreas Schwab
2008-01-09 11:07   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199849652.22083.20.camel@gargoyle \
    --to=luisgpm@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox