From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19776 invoked by alias); 8 Jan 2008 15:19:46 -0000 Received: (qmail 19766 invoked by uid 22791); 8 Jan 2008 15:19:46 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 08 Jan 2008 15:19:10 +0000 Received: from mailhub3.br.ibm.com (unknown [9.18.232.110]) by igw3.br.ibm.com (Postfix) with ESMTP id 2F1AF39019B for ; Tue, 8 Jan 2008 13:11:20 -0200 (BRDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m08FJ7Un4276326 for ; Tue, 8 Jan 2008 13:19:07 -0200 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m08FJ7P1012177 for ; Tue, 8 Jan 2008 13:19:07 -0200 Received: from [9.18.238.251] (dyn532128.br.ibm.com [9.18.238.251]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m08FJ64A012174; Tue, 8 Jan 2008 13:19:06 -0200 Subject: Re: [PATCH] Improve printf DFP support From: Thiago Jung Bauermann To: luisgpm@linux.vnet.ibm.com Cc: gdb-patches@sourceware.org In-Reply-To: <1199798856.22083.9.camel@gargoyle> References: <1199798856.22083.9.camel@gargoyle> Content-Type: text/plain Date: Tue, 08 Jan 2008 15:19:00 -0000 Message-Id: <1199805546.15225.8.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00131.txt.bz2 On Tue, 2008-01-08 at 11:27 -0200, Luis Machado wrote: > Comments? > + gdb_byte *param_ptr = (gdb_byte *) value_contents_all > (val_args[i]) > + value_offset (val_args[i]); param_ptr should be a const gdb_byte *, and the cast here should be removed. In addition, I believe the use of value_offset here is wrong. Other uses of value_offset are to obtain a memory address in the inferior address space, not in GDB's. Also, I think that value_contents should be used intead of value_contents_all so that the value's embedded_offset can be taken into account. > + dfp_ptr = (gdb_byte *) value_contents_all (dfp_value) > + + value_offset (dfp_value); Same here. PS: I don't have deep understaing of GDB's value mechanism so if someone sees I am saying something wrong here please correct me. -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center