On Thu, 2007-12-20 at 14:03 -0800, Jim Blandy wrote: > On Dec 20, 2007 12:22 PM, Luis Machado wrote: > > This simple patch fixes the issue. Any thoughts? Ok to commit? > > The only difference between those two opcodes is in their encoding --- > the action to be performed is identical. It seems silly to duplicate > the code. Could you pull the common code out into its own function, > and then have both cases simply parse their arguments and call the > function? Like so? -- Luis Machado Software Engineer IBM Linux Technology Center