From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13208 invoked by alias); 27 Oct 2007 08:19:42 -0000 Received: (qmail 13200 invoked by uid 22791); 27 Oct 2007 08:19:41 -0000 X-Spam-Check-By: sourceware.org Received: from 216-129-118-140.cust.layer42.net (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 27 Oct 2007 08:19:37 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id 2B6763B8D5; Sat, 27 Oct 2007 01:05:06 -0700 (PDT) Subject: Re: PATCH: tracepoints: Report tracepoint deletions properly From: Michael Snyder To: Jim Blandy Cc: gdb-patches@sourceware.org In-Reply-To: References: Content-Type: text/plain Date: Sat, 27 Oct 2007 09:22:00 -0000 Message-Id: <1193472863.16917.107.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00739.txt.bz2 On Fri, 2007-10-26 at 17:31 -0700, Jim Blandy wrote: > Committed as obvious. > > I don't think this matters a bit, as there seem to be no clients of > this particular event, unless I've missed something. I suspect it was meant for a gui framework that was never written. Hopefully as a result of your work, people will actually start to use tracepoints, and eventually we will want a gui framework for them. But I see no reason not to remove them for now, and add what we really need when we really need it. > gdb/ChangeLog: > 2007-10-26 Jim Blandy > > * tracepoint.c (tracepoint_operation): Report the deletion event > after we have unlinked the tracepoint from the list, and use the > proper tracepoint number. > > diff -r db46634d8623 gdb/tracepoint.c > --- a/gdb/tracepoint.c Fri Oct 26 16:39:42 2007 -0700 > +++ b/gdb/tracepoint.c Fri Oct 26 17:25:51 2007 -0700 > @@ -583,10 +583,11 @@ tracepoint_operation (struct tracepoint > ALL_TRACEPOINTS (t2) > if (t2->next == t) > { > - tracepoint_delete_event (t2->number); > t2->next = t->next; > break; > } > + > + tracepoint_delete_event (t->number); > > if (t->addr_string) > xfree (t->addr_string);