From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114052 invoked by alias); 6 Mar 2019 19:23:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114042 invoked by uid 89); 6 Mar 2019 19:23:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.1 spammy= X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 19:22:54 +0000 Received: by mail-wr1-f67.google.com with SMTP id t18so14739872wrx.2 for ; Wed, 06 Mar 2019 11:22:54 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id z14sm3021805wrv.91.2019.03.06.11.22.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 11:22:51 -0800 (PST) Subject: Re: [PATCH v2 01/22] Remove cleanups from coffread.c To: Tom Tromey , gdb-patches@sourceware.org References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-2-tom@tromey.com> From: Pedro Alves Message-ID: <1190e8e5-041f-fc53-be5a-e39b0a6c77f9@redhat.com> Date: Wed, 06 Mar 2019 19:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190227201849.32210-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00114.txt.bz2 On 02/27/2019 08:18 PM, Tom Tromey wrote: > This removes the remaining cleanups from coffread.c. > > Tested by the buildbot. However, I don't think the buildbot really > tests these code paths, and TBH I am not sure how to do it manually. > I did manage to crash an earlier version of the patch using a mingw > .exe file, though I would have thought that was only going to test > coff-pe-read.c. PE files are coff files with extra sauce. coff-pe-read.c only takes care of the PE export tables (extra sauce). > @@ -701,7 +691,7 @@ coff_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags) > if (!(objfile->flags & OBJF_READNEVER)) > bfd_map_over_sections (abfd, coff_locate_sections, (void *) info); > > - if (info->stabsects) > + if (! info->stabsects->empty()) No space after '!'. Thanks, Pedro Alves