Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
To: fedor@doc.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [Ping/RFA]: ObjC Documentation
Date: Sun, 01 Jun 2003 16:21:00 -0000	[thread overview]
Message-ID: <1190-Sun01Jun2003192231+0300-eliz@elta.co.il> (raw)
In-Reply-To: <3ED97889.30707@doc.com> (message from Adam Fedor on Sat, 31 May 2003 21:52:41 -0600)

> Date: Sat, 31 May 2003 21:52:41 -0600
> From: Adam Fedor <fedor@doc.com>
> 
> This patch hasn't been reviewed yet:
> 
> http://sources.redhat.com/ml/gdb-patches/2003-04/msg00542.htm

Sorry, my bad; I missed the original message somehow.

Here are my comments:

    +@itemx .m
    +Objective-C source file

This should be "@item .m", not @itemx.  @itemx is only used when you
have several table items which all share the same text, like this:

    @item foo
    @itemx bar
    @itemx baz
    Sample items for the same descriptive text.

    +The following commands have been extended to accept Objective-C method
    +names as line specifications:
    +
    +@itemize
    +@item @code{clear}
    +@item @code{break}
    +@item @code{info line}
    +@item @code{jump}
    +@item @code{list}
    +@end itemize

These need index entries for the special syntax of these commands
when debugging Objective-C programs.  Like this:

     @kindex clear@r{, and Objective-C}

Also, the general form of the extended commands is something I sorely
miss in this description.  Given the example:

    +@example
    +break -[Fruit create]
    +@end example

someone like me who doesn't speak fluent Objective-C is left wondering
what is "Fruit" and why do I need the `-' and the brackets.  Yes, I
know, some of that is explained further down, but a general form of
each command early on would both make the esamples more clear and
serve as an instant reminder for someone who just needs to see the
general rule.

Finally, please imagine that you are a user looking up the manual for
some specific issues pertinent to these features, and add index
entries for any issues users might wish to use to find the text you
wrote.

With those comments taken care of, the patch is approved.  Feel free
to ask if something in what I wrote is unclear.

Last, but not least: thanks for working on this!


  reply	other threads:[~2003-06-01 16:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-30 18:23 [RFA]: " Adam Fedor
2003-06-01  3:52 ` [Ping/RFA]: " Adam Fedor
2003-06-01 16:21   ` Eli Zaretskii [this message]
2003-06-07  1:50     ` Adam Fedor
2003-06-07  9:02       ` Eli Zaretskii
2003-06-07 15:39         ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190-Sun01Jun2003192231+0300-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=fedor@doc.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox