From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19860 invoked by alias); 14 Jul 2018 01:25:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19850 invoked by uid 89); 14 Jul 2018 01:25:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 01:25:40 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F057A1E48F; Fri, 13 Jul 2018 21:25:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531531539; bh=nnWPqvsiCjgDqxvKMn7RCkapvARoUC3a9KuSmdFfzFk=; h=Subject:From:To:References:Date:In-Reply-To:From; b=apBVyLun4eop9cl/mVets1ord22xGGdT4+RumoiwnR8L5Q5QoZplUpu3uJZa3rWUk mhgDmnzHl5wHVbsC51i1nBS+pX7IiE2hoYL9pt3SoPpZN1rTBw6zaP5VCIpKUrGHOw 1lP62Ndwf/f7t29joEMHfk3b3LEIuEVUnyTP5yxU= Subject: Re: [RFA 09/13] Pass the correct argument to the observer in reread_symbols From: Simon Marchi To: Tom Tromey , gdb-patches@sourceware.org References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-10-tom@tromey.com> Message-ID: <118a7e98-f0b6-8387-1918-95824f7e1ae7@simark.ca> Date: Sat, 14 Jul 2018 01:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00443.txt.bz2 On 2018-07-12 10:49 PM, Simon Marchi wrote: > On 2018-07-12 04:52 PM, Tom Tromey wrote: >> This is actually a patch I found via another route. Joel had asked me >> to write a test, but I still have not found the time to do this. >> Meanwhile, -Wunused-variable also found this error. > > Heh, this is also a case of variables that should be declared in the > narrowest scope possible. > > Simon It wasn't clear, but this LGTM. Simon