Re: [PATCH] solib-svr4.c, several memory leaks

[Luis Machado <luisgpm@linux.vnet.ibm.com>]

Folks,

GDB started acting strange today, segfaulting when trying to open some
binaries, GDB itself included. Other binaries would work OK.

Log:

-------
~/builds/gdb-head/> gdb-head-64bit/gdb/gdb gdb-head-64bit/gdb/gdb
GNU gdb 6.6.50.20070809-cvs
Copyright (C) 2007 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you
are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for
details.
This GDB was configured as "powerpc64-unknown-linux-gnu"...
startUsing host libthread_db library "/lib64/ppc970/libthread_db.so.1".
(gdb) start
Breakpoint 1 at 0x10060b3c: file gdb-head/gdb/gdb.c, line 30.
Starting program: gdb-head-64bit/gdb/gdb
BFD: reopening : No such file or directory

Segmentation fault
-------


I tracked down the root of the problem and this patch appears to be the
problem. Reverting it back fixes the problem.

Backtrace output:
-------
Program received signal SIGSEGV, Segmentation fault.
0x00000400002a8b30 in .strcmp () from /lib64/tls/libc.so.6
(gdb) bt
#0  0x00000400002a8b30 in .strcmp () from /lib64/tls/libc.so.6
#1  0x0000000010089d14 in bfd_lookup_symbol (abfd=0x1095a980,
symname=0x106de700 "r_debug_state")
    at gdb-head/gdb/solib-svr4.c:305
-------

Best regards,
Luis

On Wed, 2007-08-08 at 11:09 -0700, msnyder@sonic.net wrote:
> >
> > msnyder@sonic.net writes:
> >> 2007-08-04  Michael Snyder  <msnyder@access-company.com>
> >>
> >> 	* solib-svr4.c (open_symbol_file_object): Memory leak.
> >> 	(svr4_current_sos): Ditto.
> >> 	(enable_break): Ditto.
> >
> > Looks okay to me.
> 
> Committed.  Thanks Jim and Kevin.
> 
> 
-- 
Luis Machado
Software Engineer 
IBM Linux Technology Center
LoP Toolchain/Debuggers' team
Phone: +55 19-2132-2218
T/L: 839-2218
e-mail: luisgpm@vnet.linux.ibm.com