From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19740 invoked by alias); 17 Apr 2007 20:45:21 -0000 Received: (qmail 19730 invoked by uid 22791); 17 Apr 2007 20:45:20 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.palmsource.com (HELO mx1.palmsource.com) (12.7.175.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Apr 2007 21:45:19 +0100 Received: from localhost (localhost [127.0.0.1]) by localhost.domain.tld (Postfix) with ESMTP id 9C9555EFEC; Tue, 17 Apr 2007 13:45:17 -0700 (PDT) Received: from mx1.palmsource.com ([127.0.0.1]) by localhost (mx1.palmsource.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 21904-06; Tue, 17 Apr 2007 13:45:15 -0700 (PDT) Received: from ussunex03.svl.access-company.com (ussunm001.palmsource.com [192.168.101.12]) by mx1.palmsource.com (Postfix) with ESMTP id ECCFE5EE84; Tue, 17 Apr 2007 13:44:54 -0700 (PDT) Received: from 192.168.92.56 ([192.168.92.56]) by ussunex03.svl.access-company.com ([192.168.101.12]) via Exchange Front-End Server owa.access-company.com ([10.0.20.19]) with Microsoft Exchange Server HTTP-DAV ; Tue, 17 Apr 2007 20:46:28 +0000 Received: from svmsnyderlnx by owa.access-company.com; 17 Apr 2007 13:44:54 -0700 Subject: Re: mips-tdep.c: FP varargs fixes From: Michael Snyder To: "Maciej W. Rozycki" Cc: Daniel Jacobowitz , Mark Kettenis , gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" In-Reply-To: References: <200703231449.l2NEnQSb031165@brahms.sibelius.xs4all.nl> <20070410154430.GG10890@caradoc.them.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 17 Apr 2007 20:52:00 -0000 Message-Id: <1176842694.5381.22.camel@svmsnyderlnx.palmsource.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00270.txt.bz2 On Tue, 2007-04-17 at 15:50 +0100, Maciej W. Rozycki wrote: > On Tue, 10 Apr 2007, Daniel Jacobowitz wrote: > > > If you really want to build up some bonus points, you could extend the > > argument passing testcases to trigger some of these cases :-) > > I think gdb.base/funcargs.exp and gdb.base/varargs.exp should already > cover the interesting combinations and I would suggest that only if any > new problem pops up, they should get updated to take it into account. > > > Yes, this is OK. I'll just trust you on the underlying ABI issues, > > since you know it better than I do. It all looks sane. > > Well, GCC is the definite reference in this case ... You would think so -- but GCC has been known to get it wrong. Historically, when gcc differs from the MIPS spec, we go with the MIPS spec. Even if it means our tests fail.