From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27639 invoked by alias); 25 Dec 2019 14:14:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27628 invoked by uid 89); 25 Dec 2019 14:14:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=hat, dezember, H*x:6.1, folgendes X-HELO: sonic313-20.consmr.mail.ir2.yahoo.com Received: from sonic313-20.consmr.mail.ir2.yahoo.com (HELO sonic313-20.consmr.mail.ir2.yahoo.com) (77.238.179.187) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Dec 2019 14:14:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1577283248; bh=g9dsN5Axj1HL5VT1zlZU8XOoTtCcK9N17FCLdzQS5dM=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=gzTqA/h3wJ6ZUJCgh3iG7omF3/MEQR2bBqFludiP8jOg3z+3Nb+eDzX+uWB1q6tWAvtHnGzD1r/xWs6QTc+4Z3ju6Qrp5dMJ+H7EpkAhhzF4v+64ePePCmhN8oFn6ivs6g3pQq0jW1kpfJf96gbw7blrxugDBe+r+r0/zzADlNfJZC35nKu/h5RleNwiLOMwNiqz1Bz0XZPSD1050ZSKnaApXtr9PWzk6B5wVRcwgS+u3rkO0hLA4NeZD7VDKXfYASQIKlqMWUUcI0yFa7LV93pF4zfgH2+X9X2m1hTnRmhT9Qb853XTKURfmwGxVdtbCOif2S4LK3yCI3qBe+uNCA== Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Wed, 25 Dec 2019 14:14:08 +0000 Date: Wed, 25 Dec 2019 14:14:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <1172377766.5695945.1577283239975@mail.yahoo.com> In-Reply-To: <20191225134708.GI3865@embecosm.com> References: <20191224122452.1668-1-ssbssa.ref@yahoo.de> <20191224122452.1668-1-ssbssa@yahoo.de> <20191225134708.GI3865@embecosm.com> Subject: Re: [PATCH 1/3] pe_bfd_read_buildid memory leak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg01005.txt.bz2 Am Mittwoch, 25. Dezember 2019, 14:47:11 MEZ hat Andrew Burgess Folgendes geschrieben: > * Hannes Domani via gdb-patches [2019-12-24 = 13:24:50 +0100]: > > > bfd/ChangeLog: > > > > 2019-12-24=C2=A0 Hannes Domani=C2=A0 > > > >=C2=A0=C2=A0=C2=A0=C2=A0 * peicode.h (pe_bfd_read_buildid): Free data. > > --- > >=C2=A0 bfd/peicode.h | 2 ++ > >=C2=A0 1 file changed, 2 insertions(+) > > Patches for binutils-gdb/bfd/* should be posted to the binutils list > (binutils@sourceware.org) for review. Done. But what about patches that change both bfd/* and gdb/*? Send to both mailing lists? > Thanks, > Andrew > > > > > > > diff --git a/bfd/peicode.h b/bfd/peicode.h > > index e9d205a01a..00ccfa0a44 100644 > > --- a/bfd/peicode.h > > +++ b/bfd/peicode.h > > @@ -1396,6 +1396,8 @@ pe_bfd_read_buildid (bfd *abfd) > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > + > > +=C2=A0 free (data); > >=C2=A0 } > > > >=C2=A0 static const bfd_target * > > -- > > 2.24.1 > >