From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5174 invoked by alias); 9 Jan 2007 15:39:34 -0000 Received: (qmail 5160 invoked by uid 22791); 9 Jan 2007 15:39:34 -0000 X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Jan 2007 15:39:27 +0000 Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id l09FdHYo009421; Tue, 9 Jan 2007 15:39:17 GMT Received: from [10.1.205.4] ([10.1.255.211]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 9 Jan 2007 15:39:54 +0000 Subject: Re: [commit] Avoid using XML_StopParser if not available From: Richard Earnshaw To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org In-Reply-To: <20070109145934.GB17931@nevyn.them.org> References: <20070109145934.GB17931@nevyn.them.org> Content-Type: text/plain Date: Tue, 09 Jan 2007 15:39:00 -0000 Message-Id: <1168357156.15455.31.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0nb1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00259.txt.bz2 On Tue, 2007-01-09 at 09:59 -0500, Daniel Jacobowitz wrote: > XML_StopParser is basically an optimization. We have to check for > errors ourselves, because expat does not guarantee that it will > immediately stop calling handlers; for instance, I believe it will call > the end element handlers for anything already opened. So, we can > call it if it's available but consider a missing copy harmless. > > I've checked this in. Richard, could you let me know if it is not > enough for your version of expat? I can't readily downgrade to be > sure. > Yes, that builds without problems. R. -- Richard Earnshaw Email: Richard.Earnshaw@arm.com ARM Ltd Phone: +44 1223 400569 (Direct + VoiceMail) 110 Fulbourn Road Switchboard: +44 1223 400400 Cherry Hinton Fax: +44 1223 400410 Cambridge CB1 9NJ Web: http://www.arm.com/ UK