From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yH/MFW6ipmmOGhIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 03:57:18 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZdYBI2rN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6JNcapH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZdYBI2rN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6JNcapH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3E8ED1E08D; Tue, 03 Mar 2026 03:57:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DF801E08D for ; Tue, 03 Mar 2026 03:57:16 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 80A394BAD151 for ; Tue, 3 Mar 2026 08:57:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80A394BAD151 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZdYBI2rN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6JNcapH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZdYBI2rN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6JNcapH Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 563E84BAD14E for ; Tue, 3 Mar 2026 08:56:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 563E84BAD14E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 563E84BAD14E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772528186; cv=none; b=UcWEGh34Dab09VYNYLUTp5KgVEodBN63/FwpKhgOFvxkvqzCk09B0eIi7zRbBKOXPirMz6XDWI2wvW+tfNwahpKfRQAHpSMILpp1yC51VtMMODBaVqZPa/V6CQW6UHwOEpWBw1A9jRJEnefDlmIq1Zk97UgCXVIoIWj19ZuqhOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772528186; c=relaxed/simple; bh=wU5nNAjY9qWrfCD9B/m5IoP9C+GREJk1VXbNvWSv4e0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=B6E705ExIkhbzO0S+a1Q4l50nqPg1whOkAoYIQSBY+E2B2W4SPBS90M2u17WJ6pnBvY9/uBBpBM6B1FvHnFDnLnZlTFmY7N22zC9sJ2J/HJOY/435pLNO5oTLtF/sqV4dyWK0ye6p9Dlux6QZ1TYylv5Muj1Sayz/qhyQkuLei0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 563E84BAD14E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 44D865BCFE; Tue, 3 Mar 2026 08:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772528185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcgHaW3I9qwJ2IBXEYXNzGs5yYIgj3jeLgV3vP9fQR0=; b=ZdYBI2rNX4I8O/6QavXLemGfgYZl5+IJl1I87VnXIapBTnoGexahsOE8gmpvVTE4l32Ktr qsB6+/KQn2V1Hl/xNgkmmS1Ab7Rc9zwnPrBVs8s0wOWkBFjZKZfsuEm6XwAdVqvkTdvroD uOhP79pq9iptR1liWEGPynrVrovZ8qM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772528185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcgHaW3I9qwJ2IBXEYXNzGs5yYIgj3jeLgV3vP9fQR0=; b=W6JNcapHqX1StVufgMoQqVA5RDzuxfotjF3qWkhmHIs6jvvk5iU8fNsW7MLtJjdJ+tob7m cxW89puSQuI/bIAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZdYBI2rN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=W6JNcapH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772528185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcgHaW3I9qwJ2IBXEYXNzGs5yYIgj3jeLgV3vP9fQR0=; b=ZdYBI2rNX4I8O/6QavXLemGfgYZl5+IJl1I87VnXIapBTnoGexahsOE8gmpvVTE4l32Ktr qsB6+/KQn2V1Hl/xNgkmmS1Ab7Rc9zwnPrBVs8s0wOWkBFjZKZfsuEm6XwAdVqvkTdvroD uOhP79pq9iptR1liWEGPynrVrovZ8qM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772528185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcgHaW3I9qwJ2IBXEYXNzGs5yYIgj3jeLgV3vP9fQR0=; b=W6JNcapHqX1StVufgMoQqVA5RDzuxfotjF3qWkhmHIs6jvvk5iU8fNsW7MLtJjdJ+tob7m cxW89puSQuI/bIAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2EFE43EA69; Tue, 3 Mar 2026 08:56:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wVIyCjmipmmjJwAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 08:56:25 +0000 Message-ID: <1165cf58-be02-4303-95d2-994fcc7a2651@suse.de> Date: Tue, 3 Mar 2026 09:56:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Skip gdb.base/watchpoint-adjacent.exp on s390x To: Kevin Buettner , gdb-patches@sourceware.org References: <20260303024718.486406-1-kevinb@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260303024718.486406-1-kevinb@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 44D865BCFE X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/3/26 3:46 AM, Kevin Buettner wrote: > The watchpoint-adjacent.exp test requires both read and write hardware > watchpoints. s390x only supports write watchpoints, causing 108 test > failures when rwatch commands fail with "Target does not support this > type of hardware watchpoint." > > Add a require for allow_hw_watchpoint_access_tests to skip this test on > architectures without read watchpoint support. Hi Kevin, thanks for fixing this, LGTM. Approved-By: Tom de Vries BTW, it looks like this needs a similar fix: ... (gdb) rwatch data.u.size8twice[0]^M Target does not support this type of hardware watchpoint.^M (gdb) FAIL: gdb.base/watchpoint-unaligned.exp: fun=read_size8twice: offset=0: index=0: rwatch data.u.size8twice[0] ... Thanks, - Tom > --- > gdb/testsuite/gdb.base/watchpoint-adjacent.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/watchpoint-adjacent.exp b/gdb/testsuite/gdb.base/watchpoint-adjacent.exp > index 901a383c5b5..3c3316059ad 100644 > --- a/gdb/testsuite/gdb.base/watchpoint-adjacent.exp > +++ b/gdb/testsuite/gdb.base/watchpoint-adjacent.exp > @@ -20,7 +20,7 @@ > # Multiple inferiors are compiled, using a variety of types for the > # two fields. > > -require allow_hw_watchpoint_multi_tests > +require allow_hw_watchpoint_multi_tests allow_hw_watchpoint_access_tests > > standard_testfile >