From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8801 invoked by alias); 13 Nov 2006 17:42:47 -0000 Received: (qmail 8782 invoked by uid 22791); 13 Nov 2006 17:42:44 -0000 X-Spam-Check-By: sourceware.org Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Nov 2006 17:42:35 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.13.8/8.12.11) with ESMTP id kADHgXj9008056 for ; Mon, 13 Nov 2006 12:42:33 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kADHgWbk252928 for ; Mon, 13 Nov 2006 10:42:32 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kADHgVb3031361 for ; Mon, 13 Nov 2006 10:42:31 -0700 Received: from dufur.beaverton.ibm.com (dufur.beaverton.ibm.com [9.47.22.20]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id kADHgU07031296; Mon, 13 Nov 2006 10:42:30 -0700 Subject: [commit] signal trampoline frame cache corruption From: PAUL GILLIAM Reply-To: pgilliam@us.ibm.com To: gdb-patches@sourceware.org, Daniel Jacobowitz Cc: Mark Kettenis , Daniel Jacobowitz In-Reply-To: <20061110212202.GF1115@nevyn.them.org> References: <1162323227.3428.9.camel@dufur.beaverton.ibm.com> <200610312328.k9VNScRC012608@elgar.sibelius.xs4all.nl> <1162576236.3428.17.camel@dufur.beaverton.ibm.com> <20061110212202.GF1115@nevyn.them.org> Content-Type: multipart/mixed; boundary="=-c3e4kVR942d6QrqpvkG2" Date: Mon, 13 Nov 2006 17:42:00 -0000 Message-Id: <1163439327.3428.22.camel@dufur.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 (2.2.2-5) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00099.txt.bz2 --=-c3e4kVR942d6QrqpvkG2 Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 724 Thanks Mark and Daniel. I have committed the attached patch -=# Paul Gilliam #=- On Fri, 2006-11-10 at 16:22 -0500, Daniel Jacobowitz wrote: > On Fri, Nov 03, 2006 at 09:50:36AM -0800, PAUL GILLIAM wrote: > > Sorry about the formatting. I fixed that, and included a ChangeLog > > entry which I also forgot the first time. > > > > Now is it OK to commit? > > More formatting fixes: > > > 2006-11-03 Paul Gilliam > > Two spaces before "<"... > > > * ppc-linux-tdep.c (ppc_linux_sigtramp_cache): Only > > ... but not after ":". > > > + if (ppc_floating_point_unit_p(gdbarch)) > > Always a space before open parentheses. > > With those three fixed, feel free to repost and commit this. > --=-c3e4kVR942d6QrqpvkG2 Content-Disposition: attachment; filename=fix-sigtramp-cache.patch Content-Type: text/x-patch; name=fix-sigtramp-cache.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 1388 2006-10-31 Paul Gilliam * ppc-linux-tdep.c (ppc_linux_sigtramp_cache): Don't futz with the floating point registers if there aren't any. Index: ppc-linux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ppc-linux-tdep.c,v retrieving revision 1.78 diff -a -u -r1.78 ppc-linux-tdep.c --- ppc-linux-tdep.c 18 Apr 2006 19:20:06 -0000 1.78 +++ ppc-linux-tdep.c 31 Oct 2006 19:30:12 -0000 @@ -916,14 +916,16 @@ trad_frame_set_reg_addr (this_cache, tdep->ppc_cr_regnum, gpregs + 38 * tdep->wordsize); - /* Floating point registers. */ - for (i = 0; i < 32; i++) - { - int regnum = i + FP0_REGNUM; - trad_frame_set_reg_addr (this_cache, regnum, fpregs + i * tdep->wordsize); - } - trad_frame_set_reg_addr (this_cache, tdep->ppc_fpscr_regnum, - fpregs + 32 * tdep->wordsize); + if (ppc_floating_point_unit_p (gdbarch)) { + /* Floating point registers. */ + for (i = 0; i < 32; i++) + { + int regnum = i + FP0_REGNUM; + trad_frame_set_reg_addr (this_cache, regnum, fpregs + i * tdep->wordsize); + } + trad_frame_set_reg_addr (this_cache, tdep->ppc_fpscr_regnum, + fpregs + 32 * tdep->wordsize); + } trad_frame_set_id (this_cache, frame_id_build (base, func)); } --=-c3e4kVR942d6QrqpvkG2--