From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31859 invoked by alias); 21 Sep 2006 21:00:16 -0000 Received: (qmail 31847 invoked by uid 22791); 21 Sep 2006 21:00:16 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.palmsource.com (HELO mx2.palmsource.com) (12.7.175.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Sep 2006 21:00:12 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost.domain.tld (Postfix) with ESMTP id E8CA826C63; Thu, 21 Sep 2006 14:00:10 -0700 (PDT) Received: from mx2.palmsource.com ([127.0.0.1]) by localhost (mx2.palmsource.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 08526-04-2; Thu, 21 Sep 2006 14:00:09 -0700 (PDT) Received: from ussunex01.palmsource.com (unknown [192.168.101.9]) by mx2.palmsource.com (Postfix) with ESMTP id D4EC926BC4; Thu, 21 Sep 2006 14:00:09 -0700 (PDT) Received: from 192.168.92.59 ([192.168.92.59]) by ussunex01.palmsource.com ([192.168.101.9]) via Exchange Front-End Server owa.palmsource.com ([10.0.20.17]) with Microsoft Exchange Server HTTP-DAV ; Thu, 21 Sep 2006 21:01:03 +0000 Received: from svmsnyderlnx by owa.palmsource.com; 21 Sep 2006 14:00:09 -0700 Subject: Re: [rfa] NEWS additions for flash From: Michael Snyder To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org In-Reply-To: <20060921191424.GA1283@nevyn.them.org> References: <20060921141803.GD22556@nevyn.them.org> <1158865857.22863.1.camel@localhost.localdomain> <20060921191424.GA1283@nevyn.them.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Thu, 21 Sep 2006 21:00:00 -0000 Message-Id: <1158872409.22863.13.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00134.txt.bz2 On Thu, 2006-09-21 at 15:14 -0400, Daniel Jacobowitz wrote: > On Thu, Sep 21, 2006 at 12:10:56PM -0700, Michael Snyder wrote: > > On Thu, 2006-09-21 at 10:18 -0400, Daniel Jacobowitz wrote: > > > This patch adds news entries for the flash patches I've just checked > > > in. Is this OK? > > > > > > The next release is shaping up to be quite an improvement. > > > > On a quick scan of your (today's) patch, I don't see any tests. > > Is this testable? > > In theory, you could write some tests for it using 'gdbreplay'. But > getting gdbreplay to work in the testsuite harness would be quite > tricky, and it would be complicated by the fact that which registers > GDB asks for at connection is target dependent; I don't know how to > write generic remote protocol tests. > > I'd love to unit test this stuff. If you have any suggestions, I'm > all ears. Let's see -- there's asm-source.exp, which is implemented on an arch-by-arch basis. There's gdb.base/regs.exp, which was intended to be done the same way (but apparently was only ever implemented for one architecture). There's gdb.arch... Those are just examples -- I know it would be a hassle. I think asm-source is a very useful test, and I wish there were others (such as regs.exp) that were done in a similar arch-by-arch way.