Re: [RFC] New threadnum command for breakpoints

Frederic RISS
2006-07-31T14:00:47Z

On Mon, 2006-07-31 at 08:53 -0400, Daniel Jacobowitz wrote:
> > I must be missing something. If thread hops have to be handled
> > separately, you must be able to distinguish a condition that indicates
> > 'wrong thread' from another that just says 'wrong condition', no?
> [..]
>
> I have the feeling we could treat "wrong thread" and "wrong condition"
> exactly identically, and everything would still work.

OK. I've got the same feeling, but given the complexity of the execution
control machinery I was reluctant to change it.

bpstat_stop_status already checks for the thread match, so removing the
breakpoint_thread_match test in handle_inferior_event seems right and
should give us nearly identical code paths for thread tests carried out
using bp->thread or the $_gdb_thread variable. I'll follow up soon with
a patch doing this.

BTW, noone answered your request for comments about the variable name,
so I'll do the first iteration using $_gdb_thread.

Fred.