Re: [RFC] New threadnum command for breakpoints

Daniel Jacobowitz
2006-07-28T15:14:41Z

On Fri, Jul 28, 2006 at 04:56:03PM +0200, Frederic RISS wrote:
> * infrun.c detects breakpoint thread mismatch early and has code to
> handle thread hops correctly. This code won't be used in case the thread
> mismatch is detected only in the breakpoint condition. Couldn't that
> cause some problems? (If it's not an issue, we could certainly cleanup
> handle_inferior_event to remove that code)

It could probably be rearranged to only happen late.

> * I'm also a bit concerned about performance. Evaluating expressions is
> heavier that just comparing thread ids. At least in the context I use
> this functionality, the faster we resume, the better my system behaves.
> I haven't done any real profiling on this this point might be moot.

I really don't think this will be a problem. But if it is, we should
address it at its source - speed up the bottlenecks. An "if $thread
== 1" test shouldn't add much, since it doesn't have any target access.

--
Daniel Jacobowitz
CodeSourcery