From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1201 invoked by alias); 19 Jul 2006 08:37:50 -0000 Received: (qmail 1189 invoked by uid 22791); 19 Jul 2006 08:37:50 -0000 X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Jul 2006 08:37:46 +0000 Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id k6J8bhGf000183; Wed, 19 Jul 2006 09:37:43 +0100 (BST) Received: from pc960.cambridge.arm.com ([10.1.255.211]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 19 Jul 2006 09:37:43 +0100 Subject: Re: Initialize default floating-point model on ARM for GNU binaries From: Richard Earnshaw To: Mark Kettenis Cc: gdb-patches@sourceware.org In-Reply-To: <200607181747.k6IHlq4u030827@elgar.sibelius.xs4all.nl> References: <200607172250.k6HMoIN2009013@elgar.sibelius.xs4all.nl> <1153240315.20443.52.camel@pc960.cambridge.arm.com> <200607181747.k6IHlq4u030827@elgar.sibelius.xs4all.nl> Content-Type: text/plain Message-Id: <1153298262.20443.64.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 19 Jul 2006 08:37:00 -0000 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00252.txt.bz2 On Tue, 2006-07-18 at 18:47, Mark Kettenis wrote: > > From: Richard Earnshaw > > Date: Tue, 18 Jul 2006 17:31:56 +0100 > > > > The problem is that in the most common configuration still using the > > legacy ELF format (arm-unknown-elf) the flags are generated incorrectly > > by the compiler/assembler combination. These tools fail to correctly > > set the softfpa bit in the ELF header and the result is that gdb will > > think they contain FPA instructions when they do not. Thus I think this > > change will cause a large number of new failures on arm-elf. > > > > I guess we could fudge this by making the auto-detect code fold case 0 > > on to case EF_ARM_SOFT_FLOAT, but it would need a big comment to explain > > the background. > > That doesn't sound like a bad idea. Here's a patch with a variant of > this: leave things set to "auto" if no flag is set. That way the code > path for arm-unknown-elf will be very close to what it is right now, > which will default to "softfpa" in the end. > > ok? > > > Index: ChangeLog > from Mark Kettenis > > * arm-tdep.c (arm_gdbarch_init): Get default floating-point model > from ELF flags for binaries produced by the GNU toolchain. Thanks, this is fine. R.