From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30742 invoked by alias); 13 Dec 2014 16:21:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30727 invoked by uid 89); 13 Dec 2014 16:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx6-phx2.redhat.com Received: from mx6-phx2.redhat.com (HELO mx6-phx2.redhat.com) (209.132.183.39) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 13 Dec 2014 16:21:03 +0000 Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBDGL0O0014536; Sat, 13 Dec 2014 11:21:00 -0500 Date: Sat, 13 Dec 2014 16:21:00 -0000 From: Cleber Rosa To: Pedro Alves Cc: gdb-patches@sourceware.org, sergiodj@redhat.com, lmr@redhat.com, brobecker@adacore.com Message-ID: <1150220882.18385946.1418487658609.JavaMail.zimbra@redhat.com> In-Reply-To: <548AD6C7.1000205@redhat.com> References: <20141203103111.GB7899@adacore.com> <1418323840-2496-1-git-send-email-crosa@redhat.com> <1418323840-2496-2-git-send-email-crosa@redhat.com> <548AD6C7.1000205@redhat.com> Subject: Re: [v2,2/2] Function attributes: use shorter versions of the format macros MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00320.txt.bz2 ----- Original Message ----- > From: "Pedro Alves" > To: "Cleber Rosa" , gdb-patches@sourceware.org > Cc: sergiodj@redhat.com, lmr@redhat.com, brobecker@adacore.com > Sent: Friday, December 12, 2014 8:51:35 AM > Subject: Re: [v2,2/2] Function attributes: use shorter versions of the format macros > > On 12/11/2014 06:50 PM, Cleber Rosa wrote: > > glibc provides a wide range of function attributes that can help GCC during > > code compilation. > > > > One step further, glibc also provides in /usr/include/ansidecl.h a generic > > version of a macro called ATTRIBUTE_PRINTF, based on the format function > > attribute, and others that are more specific and shorter to write, read and > > grasp. > > We have an ansidecl.h in gdb/../include/ > that still says it's part of glibc, but the glibc copy AFAIK is long > gone. Seems to have been removed in 1997: > > 1997-06-13 10:06 Richard Henderson > ... > * ansidecl.h: Removed. > > I don't have a /usr/include/ansidecl.h in my F20 system, nor do I see > any ansidecl.h in the glibc sources. > > I'd guess your /usr/include/ansidecl.h file is really our/gcc's file, > not glibc's. I do have /usr/include/ansidecl.h on my F20 box, but you're right, it's not a part of glibc but part of binutils(-devel). > > > > > For consistency sake, let's use these shorter versions of those macros. > > Consistency with? You mean, consistency throughout? Throughout the whole repo (git://sourceware.org/git/binutils-gdb.git). The ATTRIBUTE_PRINTF_* is found on binutils/*, gold/*, libiberty/*, etc. > > > > > For more information: > > * /usr/include/ansidecl.h > > * > > https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#index-Wformat-2963 > > > > gdb/ChangeLog: > > > > * ada-lang.c (lim_warning): use shorter versions of function attributes > > macros. > > Uppercase "use". OK! > > > gdb/gdbserver/ChangeLog: > > > > * ax.c (ax_vdebug): use shorter versions of function attributes > > macros. > > Likewise. > > The patch itself looks fine to me (too). Will send a v3, thanks! > > Thanks, > Pedro Alves > >