From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4nwxF5YAqGWHyj4AWB0awg (envelope-from ) for ; Wed, 17 Jan 2024 11:30:14 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=RRIaNJJT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4E7491E0C3; Wed, 17 Jan 2024 11:30:14 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38DDC1E092 for ; Wed, 17 Jan 2024 11:30:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4537385802B for ; Wed, 17 Jan 2024 16:30:11 +0000 (GMT) Received: from sonic301-22.consmr.mail.ir2.yahoo.com (sonic301-22.consmr.mail.ir2.yahoo.com [77.238.176.99]) by sourceware.org (Postfix) with ESMTPS id 7E2953858017 for ; Wed, 17 Jan 2024 16:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E2953858017 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E2953858017 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.176.99 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705508987; cv=none; b=PV394RORKLt3BZjXzOTx4jxLlltH4HKFGP0yitSQPu8K/mdTiIWyjp2ymiFxvzrjsyEVrB524DMRxCv9ZvqlKBlWufttKemI8LY5qCd/WCwCY6BoCYWhnGXHwxYyyF5FYNZlokvEG62aoknN8NfAXHws+HRh/laNlIM6sV5tD0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705508987; c=relaxed/simple; bh=5NXXA2t22bHRkib8/nWtwdRSiFHDxPsQkejhUwNCjwg=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=PlmiIyxOIwTjHP2u5ngoqgAV4XB6RPCc8+B36N7eZzdTE70W5v4h4CdReF92honnhOCNlZfnB3Qp9SlkMBBLMLGwMyhM9M7FYl0LQuNZFU00+WIgZExYV3Itm3VbMhe5hcUHMAUSAvh1XO5TCQ9kKrFPe6QEbct2VonnmmrYpow= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1705508983; bh=5NXXA2t22bHRkib8/nWtwdRSiFHDxPsQkejhUwNCjwg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=RRIaNJJTGPaRsVg4QWQiIo5VTGVdLMGtWQidc53F104MQEiLs/QBGmVZwBuhVe2wLy/9D4Bv9CJbdm1W0CMIpf0lpAQxupy8L0iPq4ybsjHYf1iK0jPLKD2D5xULABFCMsirrkDS0xRrMfyAkZo6+bU/DRTUw7WaZtgAIVlH6IZOkmgWaMyZIfnZTCqvXrI7e2aTnKPmgFU0wC0ybDR64v3km2Aoc/byQGG/o63AsP7Dlf+CbVuE0LQFSm3HIfIlb5P2abJTQrCjwkuA05VvwmxpuDAjjZNJWQrR9nAH8yYXFeukYCHr2ygIlnjb/9AoAr3q72Wyjzss/ZpCs5C8BA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705508983; bh=oMA9E3RIvWqZI5oaPPyS9vLSELIh5wIg/NtttZMYFqU=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=Rg3weodMI4GPLPEz9jqfzKH8Q62pIIlGYndDbAof+b4YTMxmzNTb4egXPGumZyvl0KHZbJl90SiNNUPgFpBTSEX4j/MbU/ztI9Bq34upbuJrVHxIatml2PbYHsKFOOj7csCTy8SXdWQo18wgP8Du92W30ztetec6pBLEYtKaNXwq1IBZuUTDeC88EK+fHZiRQvajiZ5SC+jRi1EKpxulLti8cET0c7KwjTHr8WSYgdn6afBHy+OTuLxPbILrcWyeqrxgnKYWz/SI/cyGjo0qroF1dAHNNZ2cUlg/vh9UjKBPUERbBv91lMzq0UC7D09RbPLAnFNh7zQ8FQlTLTaj9A== X-YMail-OSG: 3BLsaA0VM1mNV2js.MPiSgVLD4cGHh20TIFz01e50sFYzZUovR6bNTRwAhpqKzz .ZXhyHAUlAEZFOZoLAPpbMh9WbTQ45tOinpBcb3lxQKfCtJkW7GoU.teHGQZqEaUv6G_FtscMPxI x_ijICNfb_xQ71Qve87H0PKgO.g_nY8WTFOqOktX009paUGJtoMgg5wZNX_zDUa6GqZCl2mcX5uL 5FhBay2wGMcbOhGRWESh13vJbtfSzVZ36RQJZ4XJnm3CPeN6wIf3KVVvEHhh6.4rLUJXREAMoGPY PvCVmfruxaBZtuXQ1XmFfx6.1j38KTky4G.vZ4qg51MrtEc9l5iLD_H_dP1Ebho0COm7dOwZ84MP Bqlaq_Ws973G66hvNOfK8UvkO6g7mPpp4Di8EvaJqGB0dj5WDNzr0ggrk47l.K521MOSMAAM9eBg orVUQMdVQVdvIFqsXW88zXJwnCYrB04EN.ehozBmAbq624p7BqAUML2aeNGWGhVPniYKoHr5bhp2 W_EVKswSLmafymg2Fq00UPWFXH3A3E5igOGruJZaae6gT04z7JnzCzcoHa0eIsaGn6vNCCMWpdNr oyO6raBhS_iCz_0ovXwtnv5YvjBvodKPEKVZD6ceeVCXbztqVxWiZAUT4M8Z1A0lPARy.0OZHzQG pLJ69DbONJtqYljHR6ik5kiE.NNlyoHzzDSWbfhdovAoz.GvxgqL01hTWBDaUppbHWCYnvJUl_tB 65gWOWagEzxcsaD_kF2Bn_pzCuWXlWofD.MJu4V3lv29o301VA_EF5b4rA7eHSNm5uPLRaWXC8wr jDgWStZll8vce_q_aWQSNBuHZHOI7tGi_TDruwhlkO2fiNYLfMwx97iuCHv81BC_VW2nwf1KT0Y9 GlxF4TndQnLxrFFqkdntDzbDRfjc4Mo8KH_LcNfo2fhnN.UQivJXuiVaH9M5hUd666iLfPTWvZdq BVWP7Kq7fFVIVcl2agtwU9hBePS4YHehXyr2jnMKXJfzXYEbSU8YjnJrM3R3EDzEcm7KdvsQLCza 2bmslqHV_euIQiPjsdRlyAh2N1_IYmVevYMIDxvfZHSTAzc50wyAEhATm3el.EBzJvNkvxz7BwUu FCvX4wxOkLrKQMqN.Tb4lru1bWn2KYTI9iX9dQ6vhz0TXALL5JYC9ykPIhCrFkymkUV1Eh5aKDa8 wc.R9sq2N58KJWcVXm8D1CLce1JHhk0GGnYTQ1yTGEEuhUXZeqr9Zmlt4w4YMhV8ErC2wjmScfyn PXpxlrQZtJm4qXean_IW1kWxltCb4DMB5Nzr_QUZ5sIr3Dkl1FdHYrOBvGzZkDuiTKHl_Thq.Ub3 01JbYZi3h5xgbxXvszB2yzSsiFRmMwuk9Iy9GRY3Cz0s30900vGkiWKnWjaxooMoVch2DS9OLhP_ uP8VXAUycLLN9wM42EwMrIiQAL72xaCNc6QxeVQNnxjLJtoN8JAZ0nvfjH1in6f_.ZeMv5M4gKww A_dUeLcf3Nj34Y7KXKeRiF7yLkczInebZqnpwUGFo61WcB59A56LFTZiq5IC.4X81CURm1rbstyG dJ.qo27wg5xGcQVSbe8JJrUfV7epXKC6s3JkC7XnAp5HuWPacCJDishe3yR8Ks2_t8VFM1Wrp6RQ L8KVGayXCM9i3lQAfxwDv5dE7cDgC7rRZrhS_.5qs2XPyDhsxKZc8UbVfop1WJ0gBrMoHIzyV8AK EQAkpmQQBPtoa__wHaxcpHJncdciubKw8VzC497ofqfDEGVfLLBECO3qjQIzjizGo6aPZukfnKbX YOb6.dHZIjFpjoV3UAxDZsChY2PWfaTy3G6k3GPkSBvl_PAJc8SeGVbzgBsanvpd3EdwjpxvdOg5 zZ6W6scPXI9I9bnIJFQftMnPTglltqC6Ep1gDLYf3ls17pEqYFfjzodcP2XIGQx.I6STZwqSssCf t_Peqnu1xAgrnvkIWC35WBTygHhnIP0HXmuxeRJE9kHbOKax2x76.Kio9_ZTjGIBcXUsd0_05VeI MIvRR.BesgzxTfZetj7RIXNrPZ9Cew0qiFrechIswHFnMMAYcN_UZ8Wob.n62aH1iIggINc7q2_q Q1xujYSNBn0VR7Qotv21poaR2xEKrv8_GXp1dBjRhFidJBbHNPKTor5FsYjFxH30NfyMhn0fXT3k A1PJvKkaVPhEX09Z4oyefo1bxuvdMekh31LBatUNXeKa0dALpayYnoPZXxBNzhMpfkvPkLfcH3XM Fehjy6Wj36bkwDMTuYuKC X-Sonic-MF: X-Sonic-ID: 72a3b8c3-1b58-4d62-988b-fb9389bfac26 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Wed, 17 Jan 2024 16:29:43 +0000 Date: Wed, 17 Jan 2024 16:29:39 +0000 (UTC) From: Hannes Domani To: Andrew Burgess , Eli Zaretskii Cc: "gdb-patches@sourceware.org" Message-ID: <1145412853.4584703.1705508979580@mail.yahoo.com> In-Reply-To: <83mst4b1qf.fsf@gnu.org> References: <048fa74bfb249273becb517d9edc9fd7a129e205.1705439706.git.aburgess@redhat.com> <83mst4b1qf.fsf@gnu.org> Subject: Re: [PATCH 5/5] gdb: remove special case completion word handling for filenames MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.22010 YMailNorrin X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Am Mittwoch, 17. Januar 2024, 13:09:38 MEZ hat Eli Zaretskii Folgendes geschrieben: > > From: Andrew Burgess > > > Cc: Andrew Burgess , > >=C2=A0=C2=A0=C2=A0=C2=A0 Eli Zaretskii > > Date: Tue, 16 Jan 2024 21:24:02 +0000 > > > > Eli, > > > > CC-ing you directly as the work I'm touching was originally done by > > you, see: > > > >=C2=A0 https://sourceware.org/pipermail/gdb-patches/2001-February/007313= .html > > > > The original email mentions 4 cases: > > > >=C2=A0 - completion on a file name in a list of file names didn't work; > >=C2=A0 - GDB would not always append a slash if the completion is a dire= ctory; > >=C2=A0 - completion failed when the file name had non-file-name characte= rs, > >=C2=A0=C2=A0=C2=A0 such as redirection, around it; > >=C2=A0 - on DOS/Windows, completion would fail with files with a drive l= etter. > > > > I believe I've tested the first 3 of these and they all seem to work > > fine still, but I don't have a working Windows machine on which I can > > test case #4.=C2=A0 I just wanted to bring this change to your attentio= n in > > case you wanted to build/test this and check that completion around > > drive letters was still working as expected. > > > Thanks.=C2=A0 I won't have enough time for this soon enough, unfortunatel= y. > Maybe someone else could do that?=C2=A0 I've taken the liberty of CC'ing > Hannes, in the hope that he could find some time for this soon. Not sure if this is exactly what you had in mind, but I tested a few things with the patches applied, and saw no problems. Absolute path: (gdb) complete file c:/gdb/build64/gdb-git-python3/g file c:/gdb/build64/gdb-git-python3/gdb/ file c:/gdb/build64/gdb-git-python3/gdbserver/ file c:/gdb/build64/gdb-git-python3/gdbsupport/ file c:/gdb/build64/gdb-git-python3/gnulib/ (gdb) complete file "c:/gdb/build64/gdb-git-python3/g file "c:/gdb/build64/gdb-git-python3/gdb/" file "c:/gdb/build64/gdb-git-python3/gdbserver/" file "c:/gdb/build64/gdb-git-python3/gdbsupport/" file "c:/gdb/build64/gdb-git-python3/gnulib/" Absolute path on the same drive: (gdb) complete file /gdb/build64/gdb-git-python3/g file /gdb/build64/gdb-git-python3/gdb/ file /gdb/build64/gdb-git-python3/gdbserver/ file /gdb/build64/gdb-git-python3/gdbsupport/ file /gdb/build64/gdb-git-python3/gnulib/ (gdb) complete file "/gdb/build64/gdb-git-python3/g file "/gdb/build64/gdb-git-python3/gdb/" file "/gdb/build64/gdb-git-python3/gdbserver/" file "/gdb/build64/gdb-git-python3/gdbsupport/" file "/gdb/build64/gdb-git-python3/gnulib/" Relative path: (gdb) pwd Working directory C:\gdb\build64\gdb-git-python3. (gdb) complete file g file gdb/ file gdbserver/ file gdbsupport/ file gnulib/ (gdb) complete file "g file "gdb/" file "gdbserver/" file "gdbsupport/" file "gnulib/" And filename-completion.exp has no fails: Running /c/src/repos/binutils-gdb.git/gdb/testsuite/gdb.base/filename-compl= etion.exp ... =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 =3D=3D=3D gdb Summary =3D=3D=3D # of expected passes=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 15