From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2748 invoked by alias); 14 Apr 2006 11:44:17 -0000 Received: (qmail 2740 invoked by uid 22791); 14 Apr 2006 11:44:16 -0000 X-Spam-Check-By: sourceware.org Received: from fra-del-02.spheriq.net (HELO fra-del-02.spheriq.net) (195.46.51.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Apr 2006 11:44:14 +0000 Received: from fra-out-01.spheriq.net (fra-out-01.spheriq.net [195.46.51.129]) by fra-del-02.spheriq.net with ESMTP id k3EBiBof026040 for ; Fri, 14 Apr 2006 11:44:11 GMT Received: from fra-cus-02.spheriq.net (fra-cus-02.spheriq.net [195.46.51.38]) by fra-out-01.spheriq.net with ESMTP id k3EBi4go009435 for ; Fri, 14 Apr 2006 11:44:05 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-02.spheriq.net with ESMTP id k3EBi25f011068 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 14 Apr 2006 11:44:03 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5913DDA43; Fri, 14 Apr 2006 11:44:02 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1914D48121; Fri, 14 Apr 2006 11:44:02 +0000 (GMT) Received: from crx549.cro.st.com (crx549.cro.st.com [164.129.44.49]) by mail1.cro.st.com (MOS 3.5.8-GR) with ESMTP id CHE73249 (AUTH "frederic riss"); Fri, 14 Apr 2006 13:43:59 +0200 (CEST) Subject: Re: [RFC] Don't lose compilation directory in Dwarf2 line-tables From: Frederic RISS To: Eli Zaretskii Cc: gdb-patches@sourceware.org In-Reply-To: References: <1144927446.14807.561.camel@crx549.cro.st.com> <8f2776cb0604131049i69e9b20fv78e60c023f245e56@mail.gmail.com> <1144999942.14807.721.camel@crx549.cro.st.com> Content-Type: multipart/mixed; boundary="=-/QqjVp4aRyLFJtnAX0PM" Date: Fri, 14 Apr 2006 11:44:00 -0000 Message-Id: <1145015039.14807.767.camel@crx549.cro.st.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00188.txt.bz2 --=-/QqjVp4aRyLFJtnAX0PM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 1219 On Fri, 2006-04-14 at 11:44 +0300, Eli Zaretskii wrote: > In addition, I think the current algorithm for searching the sources > is described in the user's manual; please see if there's something in > that description that needs to be updated with your changes. I looked at it (7.4 Specifying source directories). The algorithm that is described is the one in lookup_(partial_)symtab, and I don't think I'll change that (my patch only modifies the dwarf2 line-info reading). While reading that part, I think that I spotted a very minor issue. One sentence there reads : « Note that the executable search path is not used to locate the source files. Neither is the current working directory, unless it happens to be in the source path. » Which isn't false, but I don't think that the user has the ability to specify an empty source path, it at least always contains $cdir and $cwd. This means that the current working directory will always be used to locate source files. Also there are 2 mentions below that to 'resetting the source path to empty', but as I said, the source path is never really empty. If I'm not mistaken and if its not too much nitpicking, shall I commit something like the attached patch? --=-/QqjVp4aRyLFJtnAX0PM Content-Disposition: attachment; filename=doc.patch Content-Type: text/x-patch; name=doc.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 1403 2006-04-14 Frederic Riss * gdb.texinfo (Specifying source directories): Update the description of the source file search to reflect the fact that the source path always contains at least $cdir and $cwd. --- gdb.texinfo.orig 2006-04-14 13:18:53.000000000 +0200 +++ gdb.texinfo 2006-04-14 13:34:08.000000000 +0200 @@ -5005,8 +5005,7 @@ that---@file{/mnt/cross/foo.c}. Note that the executable search path is @emph{not} used to locate the -source files. Neither is the current working directory, unless it -happens to be in the source path. +source files. Whenever you reset or rearrange the source path, @value{GDBN} clears out any information it has cached about where source files are found and where @@ -5048,7 +5047,7 @@ directory at the time you add an entry to the source path. @item directory -Reset the source path to empty again. This requires confirmation. +Reset the source path to its initial value. This requires confirmation. @c RET-repeat for @code{directory} is explicitly disabled, but since @c repeating it would be a no-op we do not say that. (thanks to RMS) @@ -5064,7 +5063,7 @@ @enumerate @item -Use @code{directory} with no argument to reset the source path to empty. +Use @code{directory} with no argument to reset the source path to its initial value. @item Use @code{directory} with suitable arguments to reinstall the --=-/QqjVp4aRyLFJtnAX0PM--