From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9409 invoked by alias); 21 Feb 2006 10:01:32 -0000 Received: (qmail 9401 invoked by uid 22791); 21 Feb 2006 10:01:32 -0000 X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 21 Feb 2006 10:01:31 +0000 Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id k1LA0q6s029420; Tue, 21 Feb 2006 10:00:52 GMT Received: from pc960.cambridge.arm.com ([10.1.255.211]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 21 Feb 2006 10:00:52 +0000 Subject: Re: [RFA] Bail out of Thumb unwinding if there is no symbol From: Richard Earnshaw To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org In-Reply-To: <20060220214206.GA28728@nevyn.them.org> References: <20060220214206.GA28728@nevyn.them.org> Content-Type: text/plain Message-Id: <1140516048.27380.10.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Tue, 21 Feb 2006 10:26:00 -0000 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00390.txt.bz2 On Mon, 2006-02-20 at 21:42, Daniel Jacobowitz wrote: > If find_pc_partial_function fails, prologue_start won't have been > initialized. The previous effect of this code was to try to disassemble at > 0 (by luck, the variable was unset). This patch just stops unwinding when > we're stuck in a Thumb function without a symbol. > > The astute may notice that it's a bit tricky to get to this situation > with current GDB; if we don't have symbols, how do we know that we're > Thumb? Well, there's a couple ways to do it, including another > patch that I'm about to post. > > This seems like an improvement over the current situation. Lightly tested; > OK? OK. R.