From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10414 invoked by alias); 15 Feb 2006 11:51:05 -0000 Received: (qmail 10406 invoked by uid 22791); 15 Feb 2006 11:51:04 -0000 X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Feb 2006 11:51:02 +0000 Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id k1FBos6s006347; Wed, 15 Feb 2006 11:50:54 GMT Received: from pc960.cambridge.arm.com ([10.1.255.211]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 15 Feb 2006 11:50:54 +0000 Subject: Re: [PATCH] Read arm core files From: Richard Earnshaw To: Girish Shilamkar Cc: gdb-patches@sources.redhat.com In-Reply-To: <1140001485.3359.12.camel@krypton> References: <1140001485.3359.12.camel@krypton> Content-Type: text/plain Message-Id: <1140004253.28394.32.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Wed, 15 Feb 2006 11:51:00 -0000 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00316.txt.bz2 On Wed, 2006-02-15 at 11:04, Girish Shilamkar wrote: > Hi, > The patch enables gdb to read arm core files. > -Girish. Girish, This needs some work yet before it can be accepted. BTW, do you have a copyright assignment in place? If not, then we will need one before we can proceed any further. Finally, please make sure your patches are against the most recent version of CVS rather than a release. We don't incorporate new code onto existing releases. R. 2006-02-15 Girish Shilamkar * arm-linux-tdep.c Core file handler has been added. * config/arm/linux.mt Compiles corelow.c required for deprecated_add_core_fns Please take a closer look at existing ChangeLog entries and try to copy the style there. All entries are of the form * : () Sentence describing change, ending with full stop. +/* Following enums used to implement the core file support. */ Two spaces at the end of a sentence, even if it ends the entire comment. Your sentence isn't grammatically correct either: "The following enums are used to implement core file support." +enum { + ELF_NGREG = 18, /* core reg size is 72 */ All comments start with a capital letter. void +arm_linux_supply_gregset (char *buf) All functions must have a comment that precedes them describing what they do -- even in cases like this where it is fairly obvious. + regcache_raw_supply (current_regcache, FP0_REGNUM + regi, buf + 8 * regi); Watch out for line length. Wrap your code *before* you reach column 80. + warning ("wrong size gregset struct in core file"); You need to take care of i18n here. Wrap your strings thus _("My string for translation").