Re: [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope

Simon Marchi via Gdb-patches
2021-10-04T12:05:30Z

>> Ah, I had not seen this comment. So it was on purpose. Still, I think
>> that it makes it more confusing than anything. The patch LGTM.
>
> And, this follow-up commit reverts everything except the comment.
>
> Any comments?
>
> Thanks,
> - Tom
>

Is there a problem with having the lookups done with just the pc? If we
were to replace this with some C++ hash table, say std::unordered_map, it
would be std::unordered_map<CORE_ADDR /* pc */, call_site>. So doing
the lookups using just the pc in the htab makes sense to me.

Simon