Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Earnshaw <rearnsha@arm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Shaun Jackman <sjackman@gmail.com>, gdb-patches@sources.redhat.com
Subject: Re: sim/arm RedBoot meminfo syscall [PATCH]
Date: Mon, 23 Jan 2006 15:57:00 -0000	[thread overview]
Message-ID: <1138031768.1864.107.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <20060123020134.GL27224@nevyn.them.org>

On Mon, 2006-01-23 at 02:01, Daniel Jacobowitz wrote:
> On Wed, Dec 14, 2005 at 11:40:28AM -0700, Shaun Jackman wrote:
> > This patch implements the RedBoot meminfo syscall. In addition, rather
> > than ignoring unhandled syscalls, it sets errno to ENOSYS and returns
> > -1. This makes it possible to run "Hello, world!" compiled using
> > newlib and a RedBoot libgloss.
> > 
> > Cheers,
> > Shaun
> > 
> > 2005-12-14  Shaun Jackman  <sjackman@gmail.com>
> > 
> > 	* sim/arm/armos.c (ARMul_OSHandleSWI): Handle the RedBoot system
> > 	call meminfo. Return ENOSYS for unhandled RedBoot syscalls.
> 
> This looks totally plausible to me but I don't know much about it;
> Richard, any opinion on it before I approve it?
I've no objections.  The SWI code has already been grabbed, so it
doesn't really extend the interface any further.

As a general principle, however, I'd be against adding more 'top-level'
swi codes without cleaning up the interface to this module so that you
can carefully select from the command line the set of SWIs in force.

R.


  reply	other threads:[~2006-01-23 15:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-17 22:46 Shaun Jackman
2006-01-23  2:01 ` Daniel Jacobowitz
2006-01-23 15:57   ` Richard Earnshaw [this message]
2006-01-23 16:03     ` Daniel Jacobowitz
2006-01-24 23:19       ` Shaun Jackman
2006-02-02  1:49         ` Daniel Jacobowitz
2006-02-02 13:49           ` Shaun Jackman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138031768.1864.107.camel@pc960.cambridge.arm.com \
    --to=rearnsha@arm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=sjackman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox