From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9584 invoked by alias); 20 Sep 2005 06:52:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9562 invoked by uid 22791); 20 Sep 2005 06:52:27 -0000 Received: from e1.ny.us.ibm.com (HELO e1.ny.us.ibm.com) (32.97.182.141) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 20 Sep 2005 06:52:27 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id j8K6qCJ7003389 for ; Tue, 20 Sep 2005 02:52:12 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j8K6qPRI069886 for ; Tue, 20 Sep 2005 02:52:25 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11/8.13.3) with ESMTP id j8K6qOEW024600 for ; Tue, 20 Sep 2005 02:52:25 -0400 Received: from imap.linux.ibm.com (imap.rtp.raleigh.ibm.com [9.42.107.100]) by d01av04.pok.ibm.com (8.12.11/8.12.11) with ESMTP id j8K6qOPE024584; Tue, 20 Sep 2005 02:52:24 -0400 Received: by imap.linux.ibm.com (Postfix, from userid 48) id 775DE7C012; Tue, 20 Sep 2005 02:52:24 -0400 (EDT) Received: from 9.181.87.37 ([9.181.87.37]) by imap.rtp.raleigh.ibm.com (IMP) with HTTP for ; Tue, 20 Sep 2005 02:52:24 -0400 Message-ID: <1127199144.432fb1a8534fd@imap.linux.ibm.com> Date: Tue, 20 Sep 2005 06:52:00 -0000 From: Wu Zhou To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [Patch Ping]: the support of F90 subarray and substring evaluation MIME-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.7 X-SW-Source: 2005-09/txt/msg00174.txt.bz2 Hi Daniel, Thanks for your reviewing. Both patches had just been committed into cvs, with the format errors fixed and also copyright year updated. Regards - Wu Zhou Quoting Daniel Jacobowitz : > On Mon, Aug 15, 2005 at 10:07:58PM +0800, Wu Zhou wrote: > > 2005-08-15 Wu Zhou > > > > * expression.h (enum exp_opcode): Add a new operator for F90 > > subrange. > > * f-lang.h (enum f90_range_type): New enumeration type to identify > > F90 subrange type. > > * f-exp.y (yyparse): Add support for parsing F90 subrange and > > change substring parsing to subrange parsing. > > * parse.c (operator_length_standard): Set the operator length > > and args number for OP_F90_RANGE. > > * eval.c (evaluate_subexp_standard): Add code to evaluate F90 > > array section and substring. > > (value_f90_subarray): New function to evaluate F90 array section. > > (label op_f77_substr): Replaced by value_f90_subarray. Deleted. > > Sorry about the delay. This patch, and the testsuite patch, are OK. > > Two formatting comments to clean up before you check it in: > > Don't reference "label op_f77_substr" as if it were a function in > the ChangeLog. Reference the containing function, instead. > > > + /* A F90 array range operator. (for "exp:exp", "exp:", ":exp" and ":") */ > > /* A F90 array range operator (for "exp:exp", "exp:", ":exp" and ":"). */ > > Period at the end and two spaces. > > Thanks! > > > 2005-08-15 Wu Zhou > > > > * gdb.fortran/subarray.exp: New testcase to test the evaluation > > of subarray and substring variable. > > * gdb.fortran/subarray.f: New source file for the test of subarray > > and substring variable evaluation. > > * gdb.fortran/exprs.exp: Add four tests for substring evaluation > > of string constant. > > > -- > Daniel Jacobowitz > CodeSourcery, LLC > > Cheers - Wu Zhou