From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH 1/2] Don't create _Complex type name if there is no target type name
Date: Thu, 22 Oct 2020 17:40:28 +0000 (UTC) [thread overview]
Message-ID: <1126930862.3787901.1603388428370@mail.yahoo.com> (raw)
In-Reply-To: <87o8ku89ct.fsf@tromey.com>
Am Donnerstag, 22. Oktober 2020, 19:21:43 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> I didn't see a review of this.
>
> Hannes> This causes gdb to crash in strlen.
> Hannes> Happens if init_complex_type is called for a type created by
> Hannes> dbx_init_float_type in stabsread.c.
>
> Hannes> gdb/ChangeLog:
>
> Hannes> 2020-10-06 Hannes Domani <ssbssa@yahoo.de>
>
> Hannes> * gdbtypes.c (init_complex_type): Check target type name.
>
> This is ok, thanks.
Pushed both, thanks.
I'm not sure how relevant stabs nowadays is, but this crash is a regression
since gdb 9, and the fix is very simple, so maybe we should merge it to
gdb 10 as well?
Hannes
next prev parent reply other threads:[~2020-10-22 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201006154928.3298-1-ssbssa.ref@yahoo.de>
2020-10-06 15:49 ` Hannes Domani via Gdb-patches
2020-10-06 15:49 ` [PATCH 2/2] Remove gdb_assert for TYPE_CODE_METHOD in stabs reader Hannes Domani via Gdb-patches
2020-10-22 17:21 ` Tom Tromey
2020-10-22 17:21 ` [PATCH 1/2] Don't create _Complex type name if there is no target type name Tom Tromey
2020-10-22 17:40 ` Hannes Domani via Gdb-patches [this message]
2020-10-22 17:46 ` Tom Tromey
2020-10-22 18:20 ` Hannes Domani via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126930862.3787901.1603388428370@mail.yahoo.com \
--to=gdb-patches@sourceware.org \
--cc=brobecker@adacore.com \
--cc=ssbssa@yahoo.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox