From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id W3DEGpaCvmqxVyQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 11:56:06 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=tKgXXrPt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 54CC41E051; Thu, 01 Oct 2026 11:56:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A4C7B1E01F for ; Thu, 01 Oct 2026 11:56:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3B8D4BB24C9 for ; Thu, 1 Oct 2026 15:56:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3B8D4BB24C9 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=tKgXXrPt Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3BB044BA2E04 for ; Thu, 1 Oct 2026 15:55:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BB044BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3BB044BA2E04 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790870142; cv=none; b=Likrhtq+A/blCBVL94gCZ3gGVHpIbG2sj0x3/CV/bMaJmcVvJbysl7P9V2PbPkFMt4MmPO3ijMj//rhQ/Z+GLGoAxrHz0yl/fdQDMkJZcPVQywu6mQDF1I0zKpSkHnCOL6rhK32gxPCae2YSQAKZWj7Y8ll3Cm6MhNLu6UsYlDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790870142; c=relaxed/simple; bh=wvBJnbXDb6bmMKf+i14rlQj2fD6zTE7NcFKVdKp5zHM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rDQ4U7e6asKO842I76bc7wg0gk4O27G/0gydLNghiBMK2S6ZXs96kCOPqCYXuWfF8zqBq/MVBIENxtmpXhHEhp2AVg1ZQ3bJctnA95eIVnm40/MrYMXleqIoF9CLQOuVksINNHUifBD+vLwzm8RmRpHAHsBcz08aaqKigmid5vw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=tKgXXrPt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BB044BA2E04 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 691FtXZA163106 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Oct 2026 11:55:38 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 691FtXZA163106 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1790870139; bh=F1Lf68NYHy2uG9Qtj5nR2axRo80wo9p+R8vObeOiY/U=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=tKgXXrPttPvuRCzcxAaKA+aKAS803hKIAWR0iVifAq0IiStWCOYNTWHFqGP+c/gSQ NTSeFH6HFPqiyUGAEXdf+k15Q3FxPIk8BxJs16o0iaol1ow/S8wkxgJPn9mHLvWZei ApLT1nH8kbKAO0HioGTrYgEoQDNE31pIcrvQlDP+7d5yRSSfzJPHnvTuhGUWn7AS4p 9PdasZgVPQ2L3P5CEtsJtijL9dpfY5wMG7EsG6IeRfUodGpNQ+l8BpQcabG+jHVYbd e1ZOJXS+XzbR7uraB0iSfV4ebjZD6SSIVot8tfnJotHMm/8FyfBxR7ZcByrKz1WvAt bslPivFIM2nlg== Received: by simark.ca (Postfix) id C7ED21E01F; Thu, 01 Oct 2026 11:55:33 -0400 (EDT) Message-ID: <111a839a-ddea-4677-9980-18bb562243d2@polymtl.ca> Date: Thu, 1 Oct 2026 11:55:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/11] gdb: change some pointers to references in global_symbol_searcher To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-11-simon.marchi@polymtl.ca> <87mrsxxvr5.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87mrsxxvr5.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 1 Oct 2026 15:55:34 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/1/26 11:53 AM, Andrew Burgess wrote: > simon.marchi@polymtl.ca writes: > >> From: Simon Marchi >> >> add_matching_symbols and add_matching_msymbols take the container to >> add results to as a pointer, but it can never be nullptr. Pass it by >> reference instead. >> >> The objfiles are also passed by pointer to the various helper methods, >> switch that to references. >> >> Change-Id: I65d8e14f2f3152d83afbe3b348fc91a8817b87fa >> --- >> gdb/symtab.c | 39 +++++++++++++++++++-------------------- >> gdb/symtab.h | 10 +++++----- >> 2 files changed, 24 insertions(+), 25 deletions(-) >> >> diff --git a/gdb/symtab.c b/gdb/symtab.c >> index ef21f285abcd..af748190ddd5 100644 >> --- a/gdb/symtab.c >> +++ b/gdb/symtab.c > >> @@ -4945,16 +4945,16 @@ global_symbol_searcher::add_matching_msymbols >> symbol might be found via find_pc_symtab. */ >> if (m_kind == symbol_search_kind::FUNCTION >> && (find_compunit_symtab_for_pc >> - (msymbol->value_address (objfile)) != NULL)) >> + (msymbol->value_address (&objfile)) != NULL)) >> continue; >> >> if (lookup_symbol_in_objfile_from_linkage_name >> - (objfile, msymbol->linkage_name (), SEARCH_VFT).symbol != NULL) >> + (&objfile, msymbol->linkage_name (), SEARCH_VFT).symbol != NULL) >> continue; > > Two lines above here can replace NULL with nullptr. Done. > With that done: > > Approved-By: Andrew Burgess Thanks, Simon