From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29078 invoked by alias); 15 Jun 2005 11:42:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29062 invoked by uid 22791); 15 Jun 2005 11:42:54 -0000 Received: from alg145.algor.co.uk (HELO dmz.algor.co.uk) (62.254.210.145) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 15 Jun 2005 11:42:54 +0000 Received: from alg158.algor.co.uk ([62.254.210.158] helo=olympia.mips.com) by dmz.algor.co.uk with esmtp (Exim 3.35 #1 (Debian)) id 1DiWYt-0000F2-00; Wed, 15 Jun 2005 13:00:03 +0100 Received: from stockwell.mips.com ([192.168.192.238]) by olympia.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1DiWGQ-0001Ay-00; Wed, 15 Jun 2005 12:40:58 +0100 Subject: Re: [patch] MIPS16e support in simulator. From: David Ung To: Daniel Jacobowitz Cc: Eric Christopher , binutils@sourceware.org, gdb-patches@sources.redhat.com In-Reply-To: <20050614174816.GA17325@nevyn.them.org> References: <1118335933.1627.639.camel@localhost.localdomain> <20050613031833.GG9288@nevyn.them.org> <1118682165.5119.0.camel@localhost.localdomain> <20050613170353.GA19310@nevyn.them.org> <1118704956.5119.68.camel@localhost.localdomain> <20050614174816.GA17325@nevyn.them.org> Content-Type: text/plain Date: Wed, 15 Jun 2005 11:42:00 -0000 Message-Id: <1118835658.1602.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTUK-Scanner: Found to be clean X-MTUK-SpamCheck: not spam (whitelisted), SpamAssassin (score=-4.847, required 4, AWL, BAYES_00) X-SW-Source: 2005-06/txt/msg00191.txt.bz2 On Tue, 2005-06-14 at 13:48 -0400, Daniel Jacobowitz wrote: > On Mon, Jun 13, 2005 at 04:22:36PM -0700, Eric Christopher wrote: > > On Mon, 2005-06-13 at 13:03 -0400, Daniel Jacobowitz wrote: > > > On Mon, Jun 13, 2005 at 10:02:45AM -0700, Eric Christopher wrote: > > > > > > > > > So um... unfortunately, GDB does not have an active MIPS maintainer at > > > > > the moment. I do not see anything (other than your followup about the > > > > > mipsisa32 configure stanza) obviously wrong with these changes, but I > > > > > can't provide any useful review of the mips-specific bits. I don't > > > > > suppose someone on binutils@ could lend a hand? > > > > > > > > > > > > > I will, url to the original patch? > > > > > > http://sourceware.org/ml/gdb-patches/2005-06/msg00078.html > > > http://sourceware.org/ml/gdb-patches/2005-06/msg00079.html > > > > Looks like the jump instructions aren't executing the instructions in > > the delay slot? See the definition of jalr in m16.igen. > > > > I guess a good question would be asking how this patch was tested? > > > > Otherwise it looks fine. > > Given this, and the followups, the patch is OK. It looks like David > doesn't have commit access; is that right? Let me know and I'll take > care of the patch. no, I don't have write access. Could you commit it please. David.