From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4922 invoked by alias); 14 Jun 2005 11:09:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4889 invoked by uid 22791); 14 Jun 2005 11:09:51 -0000 Received: from alg145.algor.co.uk (HELO dmz.algor.co.uk) (62.254.210.145) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 14 Jun 2005 11:09:51 +0000 Received: from alg158.algor.co.uk ([62.254.210.158] helo=olympia.mips.com) by dmz.algor.co.uk with esmtp (Exim 3.35 #1 (Debian)) id 1Di9ZO-0008BQ-00; Tue, 14 Jun 2005 12:27:02 +0100 Received: from stockwell.mips.com ([192.168.192.238]) by olympia.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1Di9Gp-0006vD-00; Tue, 14 Jun 2005 12:07:51 +0100 Subject: Re: [patch] MIPS16e support in simulator. From: David Ung To: Eric Christopher Cc: Daniel Jacobowitz , binutils@sourceware.org, gdb-patches@sources.redhat.com In-Reply-To: <1118704956.5119.68.camel@localhost.localdomain> References: <1118335933.1627.639.camel@localhost.localdomain> <20050613031833.GG9288@nevyn.them.org> <1118682165.5119.0.camel@localhost.localdomain> <20050613170353.GA19310@nevyn.them.org> <1118704956.5119.68.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 14 Jun 2005 11:09:00 -0000 Message-Id: <1118747270.1621.757.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTUK-Scanner: Found to be clean X-MTUK-SpamCheck: not spam (whitelisted), SpamAssassin (score=-4.846, required 4, AWL, BAYES_00) X-SW-Source: 2005-06/txt/msg00180.txt.bz2 On Mon, 2005-06-13 at 16:22 -0700, Eric Christopher wrote: > On Mon, 2005-06-13 at 13:03 -0400, Daniel Jacobowitz wrote: > > On Mon, Jun 13, 2005 at 10:02:45AM -0700, Eric Christopher wrote: > > > > > > > So um... unfortunately, GDB does not have an active MIPS maintainer at > > > > the moment. I do not see anything (other than your followup about the > > > > mipsisa32 configure stanza) obviously wrong with these changes, but I > > > > can't provide any useful review of the mips-specific bits. I don't > > > > suppose someone on binutils@ could lend a hand? > > > > > > > > > > I will, url to the original patch? > > > > http://sourceware.org/ml/gdb-patches/2005-06/msg00078.html > > http://sourceware.org/ml/gdb-patches/2005-06/msg00079.html > > Looks like the jump instructions aren't executing the instructions in > the delay slot? See the definition of jalr in m16.igen. This is correct. The MIPS16e jrc, jalrc etc does not have a delay slot. > > I guess a good question would be asking how this patch was tested? > > Otherwise it looks fine. We've actually had MIPS16e simulator support for quite awhile at MIPS for our internal use. We've been doing nightly regressions test on MIPS16e for gcc 3.4 and gdb for more that half year now. David.