Re: [patch] MIPS16e support in simulator.

Daniel Jacobowitz
2005-06-14T17:48:27Z

On Mon, Jun 13, 2005 at 04:22:36PM -0700, Eric Christopher wrote:
> On Mon, 2005-06-13 at 13:03 -0400, Daniel Jacobowitz wrote:
> > On Mon, Jun 13, 2005 at 10:02:45AM -0700, Eric Christopher wrote:
> > >
> > > > So um... unfortunately, GDB does not have an active MIPS maintainer at
> > > > the moment. I do not see anything (other than your followup about the
> > > > mipsisa32 configure stanza) obviously wrong with these changes, but I
> > > > can't provide any useful review of the mips-specific bits. I don't
> > > > suppose someone on binutils@ could lend a hand?
> > > >
> > >
> > > I will, url to the original patch?
> >
> > http://sourceware.org/ml/gdb-patches/2005-06/msg00078.html
> > http://sourceware.org/ml/gdb-patches/2005-06/msg00079.html
>
> Looks like the jump instructions aren't executing the instructions in
> the delay slot? See the definition of jalr in m16.igen.
>
> I guess a good question would be asking how this patch was tested?
>
> Otherwise it looks fine.

Given this, and the followups, the patch is OK. It looks like David
doesn't have commit access; is that right? Let me know and I'll take
care of the patch.

--
Daniel Jacobowitz
CodeSourcery, LLC