From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2782 invoked by alias); 1 May 2005 04:45:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2670 invoked from network); 1 May 2005 04:45:43 -0000 Received: from unknown (HELO e33.co.us.ibm.com) (32.97.110.131) by sourceware.org with SMTP; 1 May 2005 04:45:43 -0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j414jg4I024904 for ; Sun, 1 May 2005 00:45:42 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j414jf1q250814 for ; Sat, 30 Apr 2005 22:45:41 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j414jfqV018480 for ; Sat, 30 Apr 2005 22:45:41 -0600 Received: from imap.linux.ibm.com (imap.rtp.raleigh.ibm.com [9.42.107.100]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j414jUhH018401; Sat, 30 Apr 2005 22:45:41 -0600 Received: by imap.linux.ibm.com (Postfix, from userid 48) id BF6B57C00C; Sun, 1 May 2005 00:45:30 -0400 (EDT) Received: from sig-9-65-98-23.mts.ibm.com (sig-9-65-98-23.mts.ibm.com [9.65.98.23]) by imap.rtp.raleigh.ibm.com (IMP) with HTTP for ; Sun, 1 May 2005 00:45:30 -0400 Message-ID: <1114922730.42745eea9efa6@imap.linux.ibm.com> Date: Sun, 01 May 2005 04:45:00 -0000 From: Wu Zhou To: Daniel Jacobowitz Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.7 X-SW-Source: 2005-05/txt/msg00006.txt.bz2 Quoting Daniel Jacobowitz : > On Sun, May 01, 2005 at 12:18:44AM -0400, Wu Zhou wrote: > > Is it ok to change the following lines in shreloc1.c/shreloc2.c from: > > > > ATTRIBUTES void fn_1 (int unused) { } > > ATTRIBUTES void fn_2 (int unused) { } > > > > to: > > > > ATTRIBUTES void fn_1 (int refered) { static_var_1 = refered; } > > ATTRIBUTES void fn_2 (int refered) { static_var_2 = refered; } > > > > Please comments. Thanks. > > Certainly. Is that enough to consider them referenced for xlc? Yes. That is enough for xlc. I had re-worked out a patch and had a test against xlc and gcc. Both worked. I had also sent out the patch. That is before I receive the above mail. My mail server seems to be somewhat slow today. :-) Cheers - Wu Zhou