From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14544 invoked by alias); 1 May 2005 04:19:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14518 invoked from network); 1 May 2005 04:19:14 -0000 Received: from unknown (HELO e33.co.us.ibm.com) (32.97.110.131) by sourceware.org with SMTP; 1 May 2005 04:19:14 -0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j414JD4I663824 for ; Sun, 1 May 2005 00:19:13 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j414JC1q244916 for ; Sat, 30 Apr 2005 22:19:12 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j414J7kl003928 for ; Sat, 30 Apr 2005 22:19:07 -0600 Received: from imap.linux.ibm.com (imap.rtp.raleigh.ibm.com [9.42.107.100]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j414Ij5K003739; Sat, 30 Apr 2005 22:19:07 -0600 Received: by imap.linux.ibm.com (Postfix, from userid 48) id 122747C00C; Sun, 1 May 2005 00:18:45 -0400 (EDT) Received: from sig-9-65-98-23.mts.ibm.com (sig-9-65-98-23.mts.ibm.com [9.65.98.23]) by imap.rtp.raleigh.ibm.com (IMP) with HTTP for ; Sun, 1 May 2005 00:18:44 -0400 Message-ID: <1114921124.427458a4c9c4a@imap.linux.ibm.com> Date: Sun, 01 May 2005 04:19:00 -0000 From: Wu Zhou To: Daniel Jacobowitz Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.7 X-SW-Source: 2005-05/txt/msg00002.txt.bz2 Quoting Daniel Jacobowitz : > This does not be long in the changelog, only in the comments. The > ChangeLog for this patch should look like: > > 2005-04-29 Paul Gilliam > Wu Zhou > > * gdb.base/shreloc.exp: Use gdb_compile_shlib. Add support for > IBM's xlc compiler. > > If you're going to post patches to this list, please find a mail client > which does not mangle line wrapping; the patch as I received it is hard > to read and can not be applied. Sorry, wish that this time it is ok. > OK, now I understand why you needed the options. We will need > -qstatsym; here's a better description: > > # IBM's xlc compiler does not add static variables to the ELFe symbol > # table by default. We need this option to make the variables show > # up in "maint print msymbols". > > Can we fix the testcase instead of adding -qdbxextra, by making the > variable referenced? Other compilers do the same optimization, and > some of them don't have a handy option to preserve the variable. > Is it ok to change the following lines in shreloc1.c/shreloc2.c from: ATTRIBUTES void fn_1 (int unused) { } ATTRIBUTES void fn_2 (int unused) { } to: ATTRIBUTES void fn_1 (int refered) { static_var_1 = refered; } ATTRIBUTES void fn_2 (int refered) { static_var_2 = refered; } Please comments. Thanks. Cheers - Wu Zhou