From: msnyder@sonic.net
To: chet.ramey@case.edu
Cc: "Jim Blandy" <jimb@codesourcery.com>,
msnyder@sonic.net, bug-readline@gnu.org,
gdb-patches@sourceware.org, chet@case.edu
Subject: Re: [Bug-readline] Re: PATCH: readline/histexpand.c, resource leak
Date: Sat, 18 Aug 2007 20:15:00 -0000 [thread overview]
Message-ID: <11112.12.7.175.2.1187468119.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <46C7528D.2000002@case.edu>
> Jim Blandy wrote:
>> It seems to me that 'words' is a malloc'ed array of malloc'ed strings,
>> so 'free (words)' still leaks storage.
>
> I don't believe there's a case where wind == -1 and any malloced strings
> exist in words[]. There's no leak unless that can happen.
Well, that isn't locally obvious -- it depends on knowing the
behavior of other code.
You may be right -- but the free won't do any harm, and in case
you're wrong (now or in the future), the free will catch it.
next prev parent reply other threads:[~2007-08-18 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 2:14 msnyder
2007-08-10 21:32 ` msnyder
2007-08-15 0:01 ` Jim Blandy
2007-08-15 0:38 ` msnyder
2007-08-15 1:20 ` Daniel Jacobowitz
2007-08-15 1:40 ` msnyder
2007-08-15 21:43 ` Jim Blandy
2007-08-18 20:12 ` [Bug-readline] " Chet Ramey
2007-08-18 20:15 ` msnyder [this message]
2007-08-20 17:03 ` Jim Blandy
2007-08-22 2:02 ` Chet Ramey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11112.12.7.175.2.1187468119.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=bug-readline@gnu.org \
--cc=chet.ramey@case.edu \
--cc=chet@case.edu \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox