From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DriGFHe551/3BAAAWB0awg (envelope-from ) for ; Sat, 26 Dec 2020 17:30:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 3FC781F0AA; Sat, 26 Dec 2020 17:30:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A0EA21E590 for ; Sat, 26 Dec 2020 17:30:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 525363864877; Sat, 26 Dec 2020 22:30:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 525363864877 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609021814; bh=1eiHIuQxP1xKKSe9nvhR/bzC/qfbBUgnDk7nA4si1Y4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ou17Rzs74gdyrWcZpVLTmoAWQ1tEk2l79kVrCBgG9vZEfCYIFLs035vVSyMd0TgAw deBAcTc5aTrSsfnNhQOzQq/ewBn0HgsWv6gg66YI0QFt9gMP5ABtPkeJhS3CzIJVBu a1R+ZCKsNZSaZBz1Fdxi4Rzf+Vot8qFsCqu/qhZw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A3E8C385DC1A for ; Sat, 26 Dec 2020 22:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A3E8C385DC1A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BQMU5dO020061 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 26 Dec 2020 17:30:10 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BQMU5dO020061 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 673061E590; Sat, 26 Dec 2020 17:30:05 -0500 (EST) Subject: Re: [PATCH v3 17/24] AArch64: Add gdbserver MTE support To: Luis Machado , gdb-patches@sourceware.org References: <20201109170435.15766-1-luis.machado@linaro.org> <20201109170435.15766-18-luis.machado@linaro.org> Message-ID: <110e4fab-1adc-4df3-23e2-3b9822274b7e@polymtl.ca> Date: Sat, 26 Dec 2020 17:30:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201109170435.15766-18-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 26 Dec 2020 22:30:05 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-09 12:04 p.m., Luis Machado via Gdb-patches wrote: > Updates on v2: > > - Updated target methods to contain a tag type parameter. > > -- > > Adds the AArch64-specific memory tagging support (MTE) by implementing the > required hooks and checks for GDBserver. > > gdbserver/ChangeLog: > > YYYY-MM-DD Luis Machado > > * Makefile.in (SFILES): Add /../gdb/nat/aarch64-mte-linux-ptrace.c. > * configure.srv (aarch64*-*-linux*): Add arch/aarch64-mte-linux.o and > nat/aarch64-mte-linux-ptrace.o. > * linux-aarch64-low.cc: Include nat/aarch64-mte-linux-ptrace.h. > (class aarch64_target) > : New method overrides. > (aarch64_target::supports_memory_tagging) > (aarch64_target::fetch_memtags) > (aarch64_target::store_memtags): New methods. > --- > gdbserver/Makefile.in | 1 + > gdbserver/configure.srv | 2 ++ > gdbserver/linux-aarch64-low.cc | 61 ++++++++++++++++++++++++++++++++++ > 3 files changed, 64 insertions(+) > > diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in > index 1969ed0ec3..45b605c3b5 100644 > --- a/gdbserver/Makefile.in > +++ b/gdbserver/Makefile.in > @@ -221,6 +221,7 @@ SFILES = \ > $(srcdir)/../gdb/arch/ppc-linux-common.c \ > $(srcdir)/../gdb/arch/riscv.c \ > $(srcdir)/../gdb/nat/aarch64-sve-linux-ptrace.c \ > + $(srcdir)/../gdb/nat/aarch64-mte-linux-ptrace.c \ > $(srcdir)/../gdb/nat/linux-btrace.c \ > $(srcdir)/../gdb/nat/linux-namespaces.c \ > $(srcdir)/../gdb/nat/linux-osdata.c \ > diff --git a/gdbserver/configure.srv b/gdbserver/configure.srv > index 833ad27c4c..0bbd990758 100644 > --- a/gdbserver/configure.srv > +++ b/gdbserver/configure.srv > @@ -52,8 +52,10 @@ case "${gdbserver_host}" in > srv_tgtobj="$srv_tgtobj nat/aarch64-linux.o" > srv_tgtobj="$srv_tgtobj arch/aarch64-insn.o" > srv_tgtobj="$srv_tgtobj arch/aarch64.o" > + srv_tgtobj="$srv_tgtobj arch/aarch64-mte-linux.o" > srv_tgtobj="$srv_tgtobj linux-aarch64-tdesc.o" > srv_tgtobj="$srv_tgtobj nat/aarch64-sve-linux-ptrace.o" > + srv_tgtobj="$srv_tgtobj nat/aarch64-mte-linux-ptrace.o" Please keep the list sorted. > +int > +aarch64_target::fetch_memtags (CORE_ADDR address, size_t len, > + gdb::byte_vector &tags, int type) > +{ > + /* Allocation tags are per-process, so any tid is fine. */ > + int tid = lwpid_of (current_thread); > + > + /* Allocation tag? */ > + if (type == 1) > + return aarch64_mte_fetch_memtags (tid, address, len, tags); Is there a define you could use instead of the magic "1"? Simon